public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Eugene Rozenfeld <erozen@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-2906] Fix profile count comparison.
Date: Tue, 27 Sep 2022 23:47:03 +0000 (GMT)	[thread overview]
Message-ID: <20220927234703.CE2463858016@sourceware.org> (raw)

https://gcc.gnu.org/g:6bf473089f3c0c6ecf101f87f705618b1707fa82

commit r13-2906-g6bf473089f3c0c6ecf101f87f705618b1707fa82
Author: Eugene Rozenfeld <erozen@microsoft.com>
Date:   Thu Sep 22 18:12:01 2022 -0700

    Fix profile count comparison.
    
    The comparison was incorrect when the counts weren't PRECISE.
    For example, crossmodule-indir-call-topn-1.c was failing
    with AutoFDO: when count_sum is 0 with quality AFDO,
    count_sum > profile_count::zero() evaluates to true. Taking that
    branch then leads to an assert in the call to to_sreal().
    
    Tested on x86_64-pc-linux-gnu.
    
    gcc/ChangeLog:
    
            * ipa-cp.cc (good_cloning_opportunity_p): Fix profile count comparison.

Diff:
---
 gcc/ipa-cp.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/ipa-cp.cc b/gcc/ipa-cp.cc
index 543a9334e2c..66bba71c068 100644
--- a/gcc/ipa-cp.cc
+++ b/gcc/ipa-cp.cc
@@ -3338,9 +3338,9 @@ good_cloning_opportunity_p (struct cgraph_node *node, sreal time_benefit,
 
   ipa_node_params *info = ipa_node_params_sum->get (node);
   int eval_threshold = opt_for_fn (node->decl, param_ipa_cp_eval_threshold);
-  if (count_sum > profile_count::zero ())
+  if (count_sum.nonzero_p ())
     {
-      gcc_assert (base_count > profile_count::zero ());
+      gcc_assert (base_count.nonzero_p ());
       sreal factor = count_sum.probability_in (base_count).to_sreal ();
       sreal evaluation = (time_benefit * factor) / size_cost;
       evaluation = incorporate_penalties (node, info, evaluation);

                 reply	other threads:[~2022-09-27 23:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220927234703.CE2463858016@sourceware.org \
    --to=erozen@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).