From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7856) id 5E1803858293; Wed, 28 Sep 2022 10:05:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E1803858293 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1664359543; bh=0JoHVlPh/d7utG6ock+rqZ/OAUPcuqlHG698fOCNXVU=; h=From:To:Subject:Date:From; b=T5rd+ABBHZB2Bxx5vL3wvHrQeUyDGZ4QIdRvEvKb3xZEd6GOx6zFpYYdhFucaHNOa ReAN7WcEokd1Szk5jWIB2P0ZZRSjVcTs7VfdECUPY4wyOAoOO9SEq5ItpXFs4xollC iuZinxX7mRKrPE5WphXTMiyMJk64IiA1xfwsUaQg= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Xi Ruoyao To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-2914] LoongArch: Use UNSPEC for fmin/fmax RTL pattern [PR105414] X-Act-Checkin: gcc X-Git-Author: Xi Ruoyao X-Git-Refname: refs/heads/master X-Git-Oldrev: 9a8212db2dd8373f5649ccd21028edd14303eb82 X-Git-Newrev: b48d7ff3570fa0ebe7790275cf020d8885120338 Message-Id: <20220928100543.5E1803858293@sourceware.org> Date: Wed, 28 Sep 2022 10:05:43 +0000 (GMT) List-Id: https://gcc.gnu.org/g:b48d7ff3570fa0ebe7790275cf020d8885120338 commit r13-2914-gb48d7ff3570fa0ebe7790275cf020d8885120338 Author: Xi Ruoyao Date: Sat Sep 24 20:47:22 2022 +0800 LoongArch: Use UNSPEC for fmin/fmax RTL pattern [PR105414] I made a mistake defining fmin/fmax RTL patterns in r13-2085: I used smin and smax in the definition mistakenly. This causes the optimizer to perform constant folding as if fmin/fmax was "really" smin/smax operations even with -fsignaling-nans. Then pr105414.c fails. We don't have fmin/fmax RTL codes for now (PR107013) so we can only use an UNSPEC for fmin and fmax patterns. gcc/ChangeLog: PR tree-optimization/105414 * config/loongarch/loongarch.md (UNSPEC_FMAX): New unspec. (UNSPEC_FMIN): Likewise. (fmax3): Use UNSPEC_FMAX instead of smax. (fmin3): Use UNSPEC_FMIN instead of smin. Diff: --- gcc/config/loongarch/loongarch.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/gcc/config/loongarch/loongarch.md b/gcc/config/loongarch/loongarch.md index 3787fd8230f..214b14bddd3 100644 --- a/gcc/config/loongarch/loongarch.md +++ b/gcc/config/loongarch/loongarch.md @@ -35,6 +35,8 @@ ;; Floating point unspecs. UNSPEC_FRINT UNSPEC_FCLASS + UNSPEC_FMAX + UNSPEC_FMIN ;; Override return address for exception handling. UNSPEC_EH_RETURN @@ -1032,8 +1034,9 @@ (define_insn "fmax3" [(set (match_operand:ANYF 0 "register_operand" "=f") - (smax:ANYF (match_operand:ANYF 1 "register_operand" "f") - (match_operand:ANYF 2 "register_operand" "f")))] + (unspec:ANYF [(use (match_operand:ANYF 1 "register_operand" "f")) + (use (match_operand:ANYF 2 "register_operand" "f"))] + UNSPEC_FMAX))] "" "fmax.\t%0,%1,%2" [(set_attr "type" "fmove") @@ -1041,8 +1044,9 @@ (define_insn "fmin3" [(set (match_operand:ANYF 0 "register_operand" "=f") - (smin:ANYF (match_operand:ANYF 1 "register_operand" "f") - (match_operand:ANYF 2 "register_operand" "f")))] + (unspec:ANYF [(use (match_operand:ANYF 1 "register_operand" "f")) + (use (match_operand:ANYF 2 "register_operand" "f"))] + UNSPEC_FMIN))] "" "fmin.\t%0,%1,%2" [(set_attr "type" "fmove")