public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Richard Sandiford <rsandifo@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-2948] aarch64: Tweak contents of flags_on/off fields Date: Thu, 29 Sep 2022 10:35:04 +0000 (GMT) [thread overview] Message-ID: <20220929103504.16E1B3858C39@sourceware.org> (raw) https://gcc.gnu.org/g:bb7f43b62a58a0f0326fd3060f0bd43e6f3ef971 commit r13-2948-gbb7f43b62a58a0f0326fd3060f0bd43e6f3ef971 Author: Richard Sandiford <richard.sandiford@arm.com> Date: Thu Sep 29 11:32:56 2022 +0100 aarch64: Tweak contents of flags_on/off fields After previous changes, it's more convenient if the flags_on and flags_off fields of all_extensions include the feature flag itself. gcc/ * common/config/aarch64/aarch64-common.cc (all_extensions): Include the feature flag in flags_on and flags_off. (aarch64_parse_extension): Update accordingly. (aarch64_get_extension_string_for_isa_flags): Likewise. Diff: --- gcc/common/config/aarch64/aarch64-common.cc | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/gcc/common/config/aarch64/aarch64-common.cc b/gcc/common/config/aarch64/aarch64-common.cc index bebcfd4c9d3..ffa83bb478f 100644 --- a/gcc/common/config/aarch64/aarch64-common.cc +++ b/gcc/common/config/aarch64/aarch64-common.cc @@ -137,10 +137,8 @@ struct aarch64_option_extension static constexpr aarch64_option_extension all_extensions[] = { #define AARCH64_OPT_EXTENSION(NAME, IDENT, C, D, E, F) \ - {NAME, AARCH64_FL_##IDENT, \ - feature_deps::IDENT ().explicit_on & ~AARCH64_FL_##IDENT, \ - feature_deps::get_flags_off (feature_deps::root_off_##IDENT) \ - & ~AARCH64_FL_##IDENT}, + {NAME, AARCH64_FL_##IDENT, feature_deps::IDENT ().explicit_on, \ + feature_deps::get_flags_off (feature_deps::root_off_##IDENT)}, #include "config/aarch64/aarch64-option-extensions.def" {NULL, 0, 0, 0} }; @@ -228,9 +226,9 @@ aarch64_parse_extension (const char *str, aarch64_feature_flags *isa_flags, { /* Add or remove the extension. */ if (adding_ext) - *isa_flags |= (opt->flags_on | opt->flag_canonical); + *isa_flags |= opt->flags_on; else - *isa_flags &= ~(opt->flags_off | opt->flag_canonical); + *isa_flags &= ~opt->flags_off; break; } } @@ -304,7 +302,7 @@ aarch64_get_extension_string_for_isa_flags if ((flags & isa_flags & (explicit_flags | ~current_flags)) == flags) { - current_flags |= opt.flag_canonical | opt.flags_on; + current_flags |= opt.flags_on; added |= opt.flag_canonical; } } @@ -319,7 +317,7 @@ aarch64_get_extension_string_for_isa_flags for (auto &opt : all_extensions) if (opt.flag_canonical & current_flags & ~isa_flags) { - current_flags &= ~(opt.flag_canonical | opt.flags_off); + current_flags &= ~opt.flags_off; outstr += "+no"; outstr += opt.name; }
reply other threads:[~2022-09-29 10:35 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220929103504.16E1B3858C39@sourceware.org \ --to=rsandifo@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).