public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-3013] c++: make some cp_trait_kind switch statements exhaustive
@ 2022-10-01 16:23 Patrick Palka
0 siblings, 0 replies; only message in thread
From: Patrick Palka @ 2022-10-01 16:23 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:c051060ade8a4392bbd4604a551a8dcb8c937f45
commit r13-3013-gc051060ade8a4392bbd4604a551a8dcb8c937f45
Author: Patrick Palka <ppalka@redhat.com>
Date: Sat Oct 1 12:21:36 2022 -0400
c++: make some cp_trait_kind switch statements exhaustive
This replaces the unreachable default case in some cp_trait_kind
switches with an exhaustive listing of the trait codes that we don't
expect to see, so that when adding a new trait we'll get a helpful
-Wswitch warning if we forget to handle the new trait in a relevant
switch.
gcc/cp/ChangeLog:
* semantics.cc (trait_expr_value): Make cp_trait_kind switch
statement exhaustive.
(finish_trait_expr): Likewise.
(finish_trait_type): Likewise.
Diff:
---
gcc/cp/semantics.cc | 31 +++++++++++++++++++++++++------
1 file changed, 25 insertions(+), 6 deletions(-)
diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc
index 66ee2186a84..4fb0675cca9 100644
--- a/gcc/cp/semantics.cc
+++ b/gcc/cp/semantics.cc
@@ -12052,10 +12052,15 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2)
case CPTK_REF_CONVERTS_FROM_TEMPORARY:
return ref_xes_from_temporary (type1, type2, /*direct_init=*/false);
- default:
- gcc_unreachable ();
- return false;
+#define DEFTRAIT_TYPE(CODE, NAME, ARITY) \
+ case CPTK_##CODE:
+#include "cp-trait.def"
+#undef DEFTRAIT_TYPE
+ /* Type-yielding traits are handled in finish_trait_type. */
+ break;
}
+
+ gcc_unreachable ();
}
/* Returns true if TYPE meets the requirements for the specified KIND,
@@ -12204,7 +12209,11 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2)
return error_mark_node;
break;
- default:
+#define DEFTRAIT_TYPE(CODE, NAME, ARITY) \
+ case CPTK_##CODE:
+#include "cp-trait.def"
+#undef DEFTRAIT_TYPE
+ /* Type-yielding traits are handled in finish_trait_type. */
gcc_unreachable ();
}
@@ -12250,9 +12259,19 @@ finish_trait_type (cp_trait_kind kind, tree type1, tree type2)
if (TYPE_REF_P (type1))
type1 = TREE_TYPE (type1);
return cv_unqualified (type1);
- default:
- gcc_unreachable ();
+
+#define DEFTRAIT_EXPR(CODE, NAME, ARITY) \
+ case CPTK_##CODE:
+#include "cp-trait.def"
+#undef DEFTRAIT_EXPR
+ /* Expression-yielding traits are handled in finish_trait_expr. */
+ case CPTK_BASES:
+ case CPTK_DIRECT_BASES:
+ /* BASES and DIRECT_BASES are handled in finish_bases. */
+ break;
}
+
+ gcc_unreachable ();
}
/* Do-nothing variants of functions to handle pragma FLOAT_CONST_DECIMAL64,
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-01 16:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-01 16:23 [gcc r13-3013] c++: make some cp_trait_kind switch statements exhaustive Patrick Palka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).