public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Olivier Hainque <hainque@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-3017] Prevent secondary warning from diagnostic tweak in gthr-vxworks.h
Date: Sun,  2 Oct 2022 09:13:49 +0000 (GMT)	[thread overview]
Message-ID: <20221002091349.3EF8A3857BA0@sourceware.org> (raw)

https://gcc.gnu.org/g:372044a67ec8346f4f308c5fe79d9e1cb6e7e6c6

commit r13-3017-g372044a67ec8346f4f308c5fe79d9e1cb6e7e6c6
Author: Olivier Hainque <hainque@adacore.com>
Date:   Thu Feb 3 15:57:32 2022 +0000

    Prevent secondary warning from diagnostic tweak in gthr-vxworks.h
    
    Within gthr-vxworks.h, we prevent C++ errors from missing
    declarations in some system headers by prepending their inclusion
    with a
    
        #pragma GCC diagnostic ignored "-Wstrict-prototypes"
    
    But Wstrict-prototypes is internally registered as valid for
    C/ObjC only, not C++, and this trick in turn triggers a Wpragma
    warning with -Wsystem-headers.
    
    This change just arranges to ignore the secondary warning locally.
    
    2021-02-03  Olivier Hainque  <hainque@adacore.com>
    
            * config/gthr-vxworks.h: Prevent Wpragma warning for the
            pragma diagnostics on Wstrict-prototypes.

Diff:
---
 libgcc/config/gthr-vxworks.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libgcc/config/gthr-vxworks.h b/libgcc/config/gthr-vxworks.h
index 9861a11511a..31c4b9f2557 100644
--- a/libgcc/config/gthr-vxworks.h
+++ b/libgcc/config/gthr-vxworks.h
@@ -38,8 +38,11 @@ see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
 #include <_vxworks-versions.h>
 
 /* Some VxWorks headers profusely use typedefs of a pointer to a function with
-   undefined number of arguments.  */
+   undefined number of arguments.  Arrange to ignore declaration errors in C++,
+   which is achievable by ignoring Wstrict-prototypes diagnostics even when the
+   option is registered as only valid for c/objc.  */
 #pragma GCC diagnostic push
+  #pragma GCC diagnostic ignored "-Wpragmas"
   #pragma GCC diagnostic ignored "-Wstrict-prototypes"
   #include <semLib.h>
 #pragma GCC diagnostic pop

                 reply	other threads:[~2022-10-02  9:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221002091349.3EF8A3857BA0@sourceware.org \
    --to=hainque@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).