public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-3027] Do not pessimize range in set_nonzero_bits.
@ 2022-10-03 11:08 Aldy Hernandez
0 siblings, 0 replies; only message in thread
From: Aldy Hernandez @ 2022-10-03 11:08 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:c0129d6b2a5f2b3cfedd213d48c95581f75312aa
commit r13-3027-gc0129d6b2a5f2b3cfedd213d48c95581f75312aa
Author: Aldy Hernandez <aldyh@redhat.com>
Date: Sun Oct 2 10:46:47 2022 +0200
Do not pessimize range in set_nonzero_bits.
Currently if we have a range of [0,0] and we set the nonzero bits to
1, the current code pessimizes the range to [0,1] because it assumes
the range is [1,1] plus the possibility of 0. This fixes the
oversight.
gcc/ChangeLog:
* value-range.cc (irange::set_nonzero_bits): Do not pessimize range.
(range_tests_nonzero_bits): New test.
Diff:
---
gcc/value-range.cc | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/gcc/value-range.cc b/gcc/value-range.cc
index e1066f4946e..6e196574de9 100644
--- a/gcc/value-range.cc
+++ b/gcc/value-range.cc
@@ -2934,6 +2934,14 @@ irange::set_nonzero_bits (const wide_int_ref &bits)
// range immediately.
if (wi::popcount (bits) == 1)
{
+ // Make sure we don't pessimize the range.
+ tree tbits = wide_int_to_tree (type (), bits);
+ if (!contains_p (tbits))
+ {
+ set_nonzero_bits (tbits);
+ return;
+ }
+
bool has_zero = contains_p (build_zero_cst (type ()));
set (type (), bits, bits);
if (has_zero)
@@ -3628,6 +3636,11 @@ range_tests_nonzero_bits ()
r1.set_nonzero_bits (0xff);
r0.union_ (r1);
ASSERT_TRUE (r0.varying_p ());
+
+ // Test that setting a nonzero bit of 1 does not pessimize the range.
+ r0.set_zero (integer_type_node);
+ r0.set_nonzero_bits (1);
+ ASSERT_TRUE (r0.zero_p ());
}
// Build an frange from string endpoints.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-03 11:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-03 11:08 [gcc r13-3027] Do not pessimize range in set_nonzero_bits Aldy Hernandez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).