public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-3051] diagnostics: Add test for fixed _Pragma location issue [PR91669]
@ 2022-10-04  1:29 Lewis Hyatt
  0 siblings, 0 replies; only message in thread
From: Lewis Hyatt @ 2022-10-04  1:29 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:70e3f71a279856eabf99bbc92c0345c3ad20b615

commit r13-3051-g70e3f71a279856eabf99bbc92c0345c3ad20b615
Author: Lewis Hyatt <lhyatt@gmail.com>
Date:   Sat Oct 1 12:05:13 2022 -0400

    diagnostics: Add test for fixed _Pragma location issue [PR91669]
    
    This PR related to _Pragma locations and diagnostic pragmas was fixed by a
    combination of r10-325 and r13-1596. Add missing test coverage.
    
    gcc/testsuite/ChangeLog:
    
            PR c/91669
            * c-c++-common/pr91669.c: New test.

Diff:
---
 gcc/testsuite/c-c++-common/pr91669.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gcc/testsuite/c-c++-common/pr91669.c b/gcc/testsuite/c-c++-common/pr91669.c
new file mode 100644
index 00000000000..1070751ed2e
--- /dev/null
+++ b/gcc/testsuite/c-c++-common/pr91669.c
@@ -0,0 +1,28 @@
+/* { dg-do compile } */
+/* { dg-additional-options "-Wreturn-type" } */
+
+/* The location of the right brace within the macro expansion can be an adhoc
+   location, because the frontend attached custom data to it.  In order for the
+   diagnostic pragma to correctly understand that the diagnostic pop occurs
+   after the function and not before, linemap_location_before_p needs to handle
+   adhoc locations within a macro map, which was broken until fixed by r10-325.
+   Verify that we get it right, both when the brace is a macro token and when it
+   is part of the macro expansion.  */
+
+#define ENDFUNC1 \
+  _Pragma("GCC diagnostic push") \
+  _Pragma("GCC diagnostic ignored \"-Wreturn-type\"") \
+  } /* { dg-bogus {-Wreturn-type} } */ \
+  _Pragma("GCC diagnostic pop")
+
+int f1 () {
+ENDFUNC1 /* { dg-bogus {in expansion of macro 'ENDFUNC1' } } */
+
+#define ENDFUNC2(term) \
+  _Pragma("GCC diagnostic push") \
+  _Pragma("GCC diagnostic ignored \"-Wreturn-type\"") \
+  term /* { dg-bogus {in definition of macro 'ENDFUNC2'} } */ \
+  _Pragma("GCC diagnostic pop")
+
+int f2 () {
+ENDFUNC2(}) /* { dg-bogus {-Wreturn-type} } */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-04  1:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04  1:29 [gcc r13-3051] diagnostics: Add test for fixed _Pragma location issue [PR91669] Lewis Hyatt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).