public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-3068] libstdc++: Fix test FAIL for old std::string ABI
@ 2022-10-04 16:46 Jonathan Wakely
  0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2022-10-04 16:46 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:5aa18176add650f481b3b9becbefce6d392cc049

commit r13-3068-g5aa18176add650f481b3b9becbefce6d392cc049
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Oct 4 17:23:45 2022 +0100

    libstdc++: Fix test FAIL for old std::string ABI
    
    libstdc++-v3/ChangeLog:
    
            * testsuite/std/ranges/adaptors/join_with/1.cc: Remove unused
            <sstream header.
            (test04): Remove constexpr for old std::string ABI and test at
            runtime.

Diff:
---
 libstdc++-v3/testsuite/std/ranges/adaptors/join_with/1.cc | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/libstdc++-v3/testsuite/std/ranges/adaptors/join_with/1.cc b/libstdc++-v3/testsuite/std/ranges/adaptors/join_with/1.cc
index efa350feb11..8b9c6c4fc9f 100644
--- a/libstdc++-v3/testsuite/std/ranges/adaptors/join_with/1.cc
+++ b/libstdc++-v3/testsuite/std/ranges/adaptors/join_with/1.cc
@@ -3,8 +3,7 @@
 
 #include <ranges>
 #include <algorithm>
-#include <sstream>
-#include <string_view>
+#include <string>
 #include <testsuite_hooks.h>
 #include <testsuite_iterators.h>
 
@@ -73,7 +72,10 @@ test03()
   return true;
 }
 
-constexpr bool
+#if _GLIBCXX_USE_CXX11_ABI
+constexpr
+#endif
+bool
 test04()
 {
   std::string rs[] = {"a", "", "b", "", "c"};
@@ -93,5 +95,9 @@ main()
   static_assert(test01());
   static_assert(test02());
   static_assert(test03());
+#if _GLIBCXX_USE_CXX11_ABI
   static_assert(test04());
+#else
+  VERIFY(test04());
+#endif
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-04 16:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 16:46 [gcc r13-3068] libstdc++: Fix test FAIL for old std::string ABI Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).