public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-3069] Remove assert from set_nonzero_bits.
@ 2022-10-04 17:53 Aldy Hernandez
  0 siblings, 0 replies; only message in thread
From: Aldy Hernandez @ 2022-10-04 17:53 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:87b0fe37a2a5916cd09586e2af83b8203f57612a

commit r13-3069-g87b0fe37a2a5916cd09586e2af83b8203f57612a
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Tue Oct 4 19:50:28 2022 +0200

    Remove assert from set_nonzero_bits.
    
    The assert removed by this patch was there to keep users from passing
    masks of incompatible types.  The self tests are passing host wide
    ints down (set_nonzero_bits (-1)), which seem to be 32 bits, whereas
    some embedded targets have integer_type_node's of 16-bits.  This is
    causing problems in m32c-elf, among others.
    
    I suppose there's no harm in passing a 32-bit mask, because
    set_nonzero_bits calls wide_int::from() to convert the mask to the
    appropriate type.  So we can remove the assert.
    
    gcc/ChangeLog:
    
            * value-range.cc (irange::set_nonzero_bits): Remove assert.

Diff:
---
 gcc/value-range.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gcc/value-range.cc b/gcc/value-range.cc
index afb26a40083..a307559b654 100644
--- a/gcc/value-range.cc
+++ b/gcc/value-range.cc
@@ -2913,7 +2913,6 @@ irange::set_nonzero_bits (const wide_int_ref &bits)
 {
   gcc_checking_assert (!undefined_p ());
   unsigned prec = TYPE_PRECISION (type ());
-  gcc_checking_assert (prec == bits.get_precision ());
 
   // Drop VARYINGs with a nonzero mask to a plain range.
   if (m_kind == VR_VARYING && bits != -1)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-04 17:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 17:53 [gcc r13-3069] Remove assert from set_nonzero_bits Aldy Hernandez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).