From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2136) id 06BA4385701D; Wed, 5 Oct 2022 12:22:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 06BA4385701D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1664972576; bh=q+id8VZ0qMff0IINFRyH4rXpuQQpIf013Yy5SQUTRF4=; h=From:To:Subject:Date:From; b=eYVLw0RGBmYDkOZPtvVL7gjocNflZs1ajd1mR7942qpyN1HjErZnNdr78G//0jDXF cgxFPfunYGahyUoFXXQLlxFe6CmwU1JPRlgkrJxvg25QuirOMucSSfE6GQ9eZEek1E Tw/K7r4L7KimVXDa2BIPKifFb7svIM5PP1WXmRso= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Aldy Hernandez To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-3086] [PR tree-optimization/107052] range-ops: Take into account nonzero mask in popcount. X-Act-Checkin: gcc X-Git-Author: Aldy Hernandez X-Git-Refname: refs/heads/master X-Git-Oldrev: ae56d600d223e996054483d7d7033ec8e258d39d X-Git-Newrev: 4c451631f722c9939260a5c2fc209802a47e525f Message-Id: <20221005122256.06BA4385701D@sourceware.org> Date: Wed, 5 Oct 2022 12:22:56 +0000 (GMT) List-Id: https://gcc.gnu.org/g:4c451631f722c9939260a5c2fc209802a47e525f commit r13-3086-g4c451631f722c9939260a5c2fc209802a47e525f Author: Aldy Hernandez Date: Tue Oct 4 17:05:10 2022 +0200 [PR tree-optimization/107052] range-ops: Take into account nonzero mask in popcount. PR tree-optimization/107052 gcc/ChangeLog: * gimple-range-op.cc (cfn_popcount::fold_range): Take into account nonzero bit mask. Diff: --- gcc/gimple-range-op.cc | 15 ++++++++++++--- gcc/testsuite/gcc.dg/tree-ssa/pr107052.c | 13 +++++++++++++ 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/gcc/gimple-range-op.cc b/gcc/gimple-range-op.cc index 5b71d1cce6d..42ebc7d6ce5 100644 --- a/gcc/gimple-range-op.cc +++ b/gcc/gimple-range-op.cc @@ -422,15 +422,24 @@ public: virtual bool fold_range (irange &r, tree type, const irange &lh, const irange &rh, relation_kind rel) const { + if (lh.undefined_p ()) + return false; + unsigned prec = TYPE_PRECISION (type); + wide_int nz = lh.get_nonzero_bits (); + wide_int pop = wi::shwi (wi::popcount (nz), prec); // Calculating the popcount of a singleton is trivial. if (lh.singleton_p ()) { - wide_int nz = lh.get_nonzero_bits (); - wide_int pop = wi::shwi (wi::popcount (nz), TYPE_PRECISION (type)); r.set (type, pop, pop); return true; } - return cfn_ffs::fold_range (r, type, lh, rh, rel); + if (cfn_ffs::fold_range (r, type, lh, rh, rel)) + { + int_range<2> tmp (type, wi::zero (prec), pop); + r.intersect (tmp); + return true; + } + return false; } } op_cfn_popcount; diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr107052.c b/gcc/testsuite/gcc.dg/tree-ssa/pr107052.c new file mode 100644 index 00000000000..88b5213160d --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr107052.c @@ -0,0 +1,13 @@ +// { dg-do compile } +// { dg-options "-O2 -fdump-tree-evrp" } + +void link_failure(); +void f(int a) +{ + a &= 0x300; + int b = __builtin_popcount(a); + if (b > 3) + link_failure(); +} + +// { dg-final { scan-tree-dump-not "link_failure" "evrp" } }