From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2136) id 490123898386; Thu, 6 Oct 2022 20:41:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 490123898386 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1665088863; bh=dQk+YMpxr4+dBITz1c4hqBtcee38rnXBGle4y9yIA+w=; h=From:To:Subject:Date:From; b=SOW51A72Ek1UnRu5gzWOe9acmdI2REW+t4Q41HatX0UoR7s+YklccK/rllk04zVyq 7rivU2+9wHMhAypJ67ncdt2Mop08kSaAq+Ota7yx7PgSS7dOtzVCGplBbEtc9V1ZIU oNb6AZaOx01ki+E1BZemvjB/zlAv0uEKkFHaAD0A= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Aldy Hernandez To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-3139] [PR107170] Avoid copying incompatible types in legacy VRP. X-Act-Checkin: gcc X-Git-Author: Aldy Hernandez X-Git-Refname: refs/heads/master X-Git-Oldrev: 629b4813e91aba0a8fc9b18434ec1808776a4b3d X-Git-Newrev: 49b9a8c8cc498b1ed2f566bee858e651e14ba37b Message-Id: <20221006204103.490123898386@sourceware.org> Date: Thu, 6 Oct 2022 20:41:03 +0000 (GMT) List-Id: https://gcc.gnu.org/g:49b9a8c8cc498b1ed2f566bee858e651e14ba37b commit r13-3139-g49b9a8c8cc498b1ed2f566bee858e651e14ba37b Author: Aldy Hernandez Date: Thu Oct 6 19:11:08 2022 +0200 [PR107170] Avoid copying incompatible types in legacy VRP. Legacy VRP is calling ranger deep inside the bowels, and then trying to copy an incompatible type. My previous patch in this area assumed that the only possibility out of vr_values::get_value_range for an unsupported type was VARYING, but UNDEFINED can also be returned. PR tree-optimization/107170 gcc/ChangeLog: * vr-values.cc (vr_values::range_of_expr): Do not die on unsupported types. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/pr107170.c: New test. Diff: --- gcc/testsuite/gcc.dg/tree-ssa/pr107170.c | 8 ++++++++ gcc/vr-values.cc | 24 +++++++++++++----------- 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr107170.c b/gcc/testsuite/gcc.dg/tree-ssa/pr107170.c new file mode 100644 index 00000000000..7a5a4a363f2 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr107170.c @@ -0,0 +1,8 @@ +// { dg-do compile } +// { dg-options "-O2" } + +int main() { + double a; + if (__builtin_signbit(a)) + __builtin_abort(); +} diff --git a/gcc/vr-values.cc b/gcc/vr-values.cc index 626a9189472..71fed1e6a7e 100644 --- a/gcc/vr-values.cc +++ b/gcc/vr-values.cc @@ -184,21 +184,23 @@ vr_values::range_of_expr (vrange &r, tree expr, gimple *stmt) if (const value_range *vr = get_value_range (expr, stmt)) { + if (!vr->supports_type_p (TREE_TYPE (expr))) + { + // vr_values::extract_range_basic() use of ranger's + // fold_range() can create a situation where we are asked + // for the range of an unsupported legacy type. Since + // get_value_range() above will return varying or undefined + // for such types, avoid copying incompatible range types. + if (vr->undefined_p ()) + r.set_undefined (); + else + r.set_varying (TREE_TYPE (expr)); + return true; + } if (vr->undefined_p () || vr->constant_p ()) r = *vr; else { - if (!vr->supports_type_p (TREE_TYPE (expr))) - { - // vr_values::extract_range_basic() use of ranger's - // fold_range() can create a situation where we are - // asked for the range of an unsupported legacy type. - // Since get_value_range() above will return varying for - // such types, avoid copying incompatible range types. - gcc_checking_assert (vr->varying_p ()); - r.set_varying (TREE_TYPE (expr)); - return true; - } value_range tmp = *vr; tmp.normalize_symbolics (); r = tmp;