public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r11-10303] tree-optimization/106112 - fix CSE from wider operation
Date: Tue, 11 Oct 2022 13:04:23 +0000 (GMT)	[thread overview]
Message-ID: <20221011130423.9F75C3851172@sourceware.org> (raw)

https://gcc.gnu.org/g:b7878f05553bcf569a987dff8a7ef8b045b8d26c

commit r11-10303-gb7878f05553bcf569a987dff8a7ef8b045b8d26c
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Jun 28 13:57:29 2022 +0200

    tree-optimization/106112 - fix CSE from wider operation
    
    The following fixes a mistake in looking up an extended operand
    in the CSE of a truncated operation.
    
    2022-06-28  Richard Biener  <rguenther@suse.de>
    
            PR tree-optimization/106112
            * tree-ssa-sccvn.c (valueized_wider_op): Properly extend
            a constant operand according to its type.
    
            * gcc.dg/torture/pr106112.c: New testcase.
    
    (cherry picked from commit 2dbb45d6dc0d20dc159b3d8e27ebb6825074827a)

Diff:
---
 gcc/testsuite/gcc.dg/torture/pr106112.c | 16 ++++++++++++++++
 gcc/tree-ssa-sccvn.c                    |  2 +-
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/torture/pr106112.c b/gcc/testsuite/gcc.dg/torture/pr106112.c
new file mode 100644
index 00000000000..bd7f63c0935
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr106112.c
@@ -0,0 +1,16 @@
+/* { dg-do run } */
+
+__INT32_TYPE__ a = 5, b, c, d;
+__UINT64_TYPE__ e = 20862985922;
+int main()
+{
+  __UINT32_TYPE__ f = 4294967292;
+  e = e | f;
+  c = -1 % ((~f ^ 4294967292) - (e - d));
+  b = ~-~e % ~-d;
+  if (b)
+    a = 0;
+  if (a < 1)
+    __builtin_abort();
+  return 0;
+}
diff --git a/gcc/tree-ssa-sccvn.c b/gcc/tree-ssa-sccvn.c
index eaa97566d35..5d773dd3239 100644
--- a/gcc/tree-ssa-sccvn.c
+++ b/gcc/tree-ssa-sccvn.c
@@ -4843,7 +4843,7 @@ valueized_wider_op (tree wide_type, tree op, bool allow_truncate)
 
   /* For constants simply extend it.  */
   if (TREE_CODE (op) == INTEGER_CST)
-    return wide_int_to_tree (wide_type, wi::to_wide (op));
+    return wide_int_to_tree (wide_type, wi::to_widest (op));
 
   return NULL_TREE;
 }

                 reply	other threads:[~2022-10-11 13:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221011130423.9F75C3851172@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).