public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Thomas Schwinge <tschwinge@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc/devel/rust/master] lang.opt: Remove overzealous warning initialisation Date: Thu, 13 Oct 2022 07:04:57 +0000 (GMT) [thread overview] Message-ID: <20221013070457.8D9743858C56@sourceware.org> (raw) https://gcc.gnu.org/g:4134055f1855ea5293fa598fc3503e07a11d1d9d commit 4134055f1855ea5293fa598fc3503e07a11d1d9d Author: Arthur Cohen <arthur.cohen@embecosm.com> Date: Wed Oct 5 10:05:26 2022 +0200 lang.opt: Remove overzealous warning initialisation pipeline: Add default warning initialisation Option initialisations in lang.opt files are applied globally, so the test suites of other frontend would fail when the rust language was enabled. This should be reversed once @tschwinge `LangInit` option is merged Diff: --- gcc/rust/lang.opt | 6 +++--- gcc/rust/rust-lang.cc | 7 +++++++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/gcc/rust/lang.opt b/gcc/rust/lang.opt index bb3b9983862..40297ad314d 100644 --- a/gcc/rust/lang.opt +++ b/gcc/rust/lang.opt @@ -39,7 +39,7 @@ Rust ; Documented in c.opt Wunused-variable -Rust Var(warn_unused_variable) Init(1) Warning +Rust Var(warn_unused_variable) Warning ; documented in common.opt Wunused-const-variable @@ -47,11 +47,11 @@ Rust Warning Alias(Wunused-const-variable=, 2, 0) Warn when a const variable is unused. Wunused-const-variable= -Rust Joined RejectNegative UInteger Var(warn_unused_const_variable) Init(1) Warning LangEnabledBy(Rust,Wunused-variable, 1, 0) IntegerRange(0, 2) +Rust Joined RejectNegative UInteger Var(warn_unused_const_variable) Warning LangEnabledBy(Rust,Wunused-variable, 1, 0) IntegerRange(0, 2) Warn when a const variable is unused. Wunused-result -Rust Var(warn_unused_result) Init(1) Warning +Rust Var(warn_unused_result) Warning Warn if a caller of a function, marked with attribute warn_unused_result, does not use its return value. frust-crate= diff --git a/gcc/rust/rust-lang.cc b/gcc/rust/rust-lang.cc index c9af790f66b..72f3dc09bab 100644 --- a/gcc/rust/rust-lang.cc +++ b/gcc/rust/rust-lang.cc @@ -162,6 +162,13 @@ grs_langhook_init_options_struct (struct gcc_options *opts) * builtins */ opts->x_flag_wrapv = 1; + /* We need to warn on unused variables by default */ + opts->x_warn_unused_variable = 1; + /* For const variables too */ + opts->x_warn_unused_const_variable = 1; + /* And finally unused result for #[must_use] */ + opts->x_warn_unused_result = 1; + // nothing yet - used by frontends to change specific options for the language Rust::Session::get_instance ().init_options (); }
reply other threads:[~2022-10-13 7:04 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221013070457.8D9743858C56@sourceware.org \ --to=tschwinge@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).