public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Andre Simoes Dias Vieira <avieira@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-3268] vect: Don't pattern match BITFIELD_REF's of non-integrals [PR107226] Date: Thu, 13 Oct 2022 09:35:31 +0000 (GMT) [thread overview] Message-ID: <20221013093531.7E8473857BB5@sourceware.org> (raw) https://gcc.gnu.org/g:7f9a7465c863e482708d2a00f5f7ff91ae3a7e0b commit r13-3268-g7f9a7465c863e482708d2a00f5f7ff91ae3a7e0b Author: Andre Vieira <andre.simoesdiasvieira@arm.com> Date: Thu Oct 13 10:34:27 2022 +0100 vect: Don't pattern match BITFIELD_REF's of non-integrals [PR107226] The original patch supported matching the vect_recog_bitfield_ref_pattern for BITFIELD_REF's where the first operand didn't have a INTEGRAL_TYPE_P type. That means it would also match vectors, leading to regressions in targets that supported vectorization of those. gcc/ChangeLog: PR tree-optimization/107226 * tree-vect-patterns.cc (vect_recog_bitfield_ref_pattern): Reject BITFIELD_REF's with non integral typed first operands. Diff: --- gcc/tree-vect-patterns.cc | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/gcc/tree-vect-patterns.cc b/gcc/tree-vect-patterns.cc index 0cc315d3126..6afd57a50c4 100644 --- a/gcc/tree-vect-patterns.cc +++ b/gcc/tree-vect-patterns.cc @@ -1913,6 +1913,7 @@ vect_recog_bitfield_ref_pattern (vec_info *vinfo, stmt_vec_info stmt_info, return NULL; if (!INTEGRAL_TYPE_P (TREE_TYPE (bf_ref)) + || !INTEGRAL_TYPE_P (TREE_TYPE (container)) || TYPE_MODE (TREE_TYPE (container)) == E_BLKmode) return NULL; @@ -1921,25 +1922,7 @@ vect_recog_bitfield_ref_pattern (vec_info *vinfo, stmt_vec_info stmt_info, tree ret = gimple_assign_lhs (first_stmt); tree ret_type = TREE_TYPE (ret); bool shift_first = true; - tree vectype; - - /* If the first operand of the BIT_FIELD_REF is not an INTEGER type, convert - it to one of the same width so we can perform the necessary masking and - shifting. */ - if (!INTEGRAL_TYPE_P (TREE_TYPE (container))) - { - unsigned HOST_WIDE_INT container_size = - tree_to_uhwi (TYPE_SIZE (TREE_TYPE (container))); - tree int_type = build_nonstandard_integer_type (container_size, true); - pattern_stmt - = gimple_build_assign (vect_recog_temp_ssa_var (int_type), - VIEW_CONVERT_EXPR, container); - vectype = get_vectype_for_scalar_type (vinfo, int_type); - container = gimple_assign_lhs (pattern_stmt); - append_pattern_def_seq (vinfo, stmt_info, pattern_stmt, vectype); - } - else - vectype = get_vectype_for_scalar_type (vinfo, TREE_TYPE (container)); + tree vectype = get_vectype_for_scalar_type (vinfo, TREE_TYPE (container)); /* We move the conversion earlier if the loaded type is smaller than the return type to enable the use of widening loads. */
reply other threads:[~2022-10-13 9:35 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221013093531.7E8473857BB5@sourceware.org \ --to=avieira@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).