From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2136) id 4CE4D386547E; Fri, 14 Oct 2022 14:38:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4CE4D386547E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1665758337; bh=f6nTWMb/O9twhGEu9zaKeQVgB1s2fWLea3TivAUW+m4=; h=From:To:Subject:Date:From; b=YTzKAhvL82NzxXk9N6WIrCRb5ThnLew/ef8Hh/74ORKc1DrB/1cvCQ6dZIzvQ/CK5 9FidV4DK9Ic3m9Uzu1qz8I69nrjUHagSmVW3YTHvSvKfEg/u4snPFEu87HAUGb0+/6 pcyjri/aotzjpMlNORCU4fd7UjyhBT0jqVl6xGj8= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Aldy Hernandez To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-3305] Check rvc_normal in real_isdenormal. X-Act-Checkin: gcc X-Git-Author: Aldy Hernandez X-Git-Refname: refs/heads/master X-Git-Oldrev: 0dd9dd1fdfca1219bbe3ac460b50c6776b427119 X-Git-Newrev: 3dfeda095bd43c011fdc3834b9cec39bb9a73a1f Message-Id: <20221014143857.4CE4D386547E@sourceware.org> Date: Fri, 14 Oct 2022 14:38:57 +0000 (GMT) List-Id: https://gcc.gnu.org/g:3dfeda095bd43c011fdc3834b9cec39bb9a73a1f commit r13-3305-g3dfeda095bd43c011fdc3834b9cec39bb9a73a1f Author: Aldy Hernandez Date: Fri Oct 14 12:08:11 2022 +0200 Check rvc_normal in real_isdenormal. [-Inf, -Inf] is being flushed to [-Inf, -0.0] because real_isdenormal is being overly pessimistic. It is missing a check for rvc_normal. This doesn't cause problems in real.cc because all uses of real_isdenormal are already on the rvc_normal path. The uses in value-range.cc however, are not. This patch adds a check for rvc_normal. gcc/ChangeLog: * real.h (real_isdenormal): Check rvc_normal. * value-range.cc (range_tests_floats): New test. Diff: --- gcc/real.h | 2 +- gcc/value-range.cc | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gcc/real.h b/gcc/real.h index f9528d765ec..306e9593866 100644 --- a/gcc/real.h +++ b/gcc/real.h @@ -290,7 +290,7 @@ extern bool real_issignaling_nan (const REAL_VALUE_TYPE *); inline bool real_isdenormal (const REAL_VALUE_TYPE *r) { - return (r->sig[SIGSZ-1] & SIG_MSB) == 0; + return r->cl == rvc_normal && (r->sig[SIGSZ-1] & SIG_MSB) == 0; } /* Determine whether a floating-point value X is finite. */ diff --git a/gcc/value-range.cc b/gcc/value-range.cc index 6b4f3dddcd5..ee15eb35df8 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -4014,6 +4014,11 @@ range_tests_floats () r1.clear_nan (); r0.intersect (r1); ASSERT_TRUE (r0.undefined_p ()); + + // Make sure [-Inf, -Inf] doesn't get normalized. + r0 = frange_float ("-Inf", "-Inf"); + ASSERT_TRUE (real_isinf (&r0.lower_bound (), true)); + ASSERT_TRUE (real_isinf (&r0.upper_bound (), true)); } void