public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-3342] Fortran: NULL pointer dereference in gfc_simplify_image_index [PR104330]
Date: Mon, 17 Oct 2022 20:47:20 +0000 (GMT)	[thread overview]
Message-ID: <20221017204720.3C2983858D3C@sourceware.org> (raw)

https://gcc.gnu.org/g:84807af0ca6dfdb81abb8e925ce32acbcab29868

commit r13-3342-g84807af0ca6dfdb81abb8e925ce32acbcab29868
Author: Steve Kargl <kargl@gcc.gnu.org>
Date:   Mon Oct 17 22:42:40 2022 +0200

    Fortran: NULL pointer dereference in gfc_simplify_image_index [PR104330]
    
    gcc/fortran/ChangeLog:
    
            PR fortran/104330
            * simplify.cc (gfc_simplify_image_index): Do not dereference NULL
            pointer.
    
    gcc/testsuite/ChangeLog:
    
            PR fortran/104330
            * gfortran.dg/pr104330.f90: New test.

Diff:
---
 gcc/fortran/simplify.cc                |  2 +-
 gcc/testsuite/gfortran.dg/pr104330.f90 | 20 ++++++++++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
index 6ac92cf9db8..9c2fea8c5f2 100644
--- a/gcc/fortran/simplify.cc
+++ b/gcc/fortran/simplify.cc
@@ -8266,7 +8266,7 @@ gfc_simplify_image_index (gfc_expr *coarray, gfc_expr *sub)
     if (ref->type == REF_COMPONENT)
       as = ref->u.ar.as;
 
-  if (as->type == AS_DEFERRED)
+  if (!as || as->type == AS_DEFERRED)
     return NULL;
 
   /* "valid sequence of cosubscripts" are required; thus, return 0 unless
diff --git a/gcc/testsuite/gfortran.dg/pr104330.f90 b/gcc/testsuite/gfortran.dg/pr104330.f90
new file mode 100644
index 00000000000..9ff48e2f6cc
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr104330.f90
@@ -0,0 +1,20 @@
+! { dg-do compile }
+! { dg-options "-fcoarray=lib" }
+!
+! PR fortran/104330 - ICE in gfc_simplify_image_index
+! Contributed by G.Steinmetz
+
+program p
+  implicit none
+  type t
+  end type t
+  class(*), allocatable :: x[:]
+  class(t), allocatable :: y[:]
+  type(t),  allocatable :: z[:]
+  allocate (real :: x[*])
+  print *, image_index(x, [1])
+  allocate (t :: y[*])
+  print *, image_index(y, [1])
+  allocate (t :: z[*])
+  print *, image_index(z, [1])
+end

                 reply	other threads:[~2022-10-17 20:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017204720.3C2983858D3C@sourceware.org \
    --to=anlauf@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).