From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2119) id A41583857C5C; Mon, 17 Oct 2022 23:24:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A41583857C5C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1666049071; bh=n5ftZYYsfkn1QzY2fp8Z/6k4hdjCkwiTbuQvpOhYoYQ=; h=From:To:Subject:Date:From; b=AE2/GUImB9cji+QnU9a/TvxUejzoCuRq8uqMeu7YzfXu3K4mXrW3Dd5YtmA9RZaC1 BFKwS1qdEZA4Lw/sXjVjoei/PlRisKTh4hKuNTlB46dg4dnH04OJiLO0N72B1pofzN oucRU1m5KAEA3dEHiB73tIo/esaduhKfSLgmqUGk= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jeff Law To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-3344] Add missing splitter for H8 X-Act-Checkin: gcc X-Git-Author: Jeff Law X-Git-Refname: refs/heads/master X-Git-Oldrev: 9072db9d5b549db5e2f14335ac0adc7735d43bc6 X-Git-Newrev: 43ee3f64cb519f2675fa1771007d4aa3baba944f Message-Id: <20221017232431.A41583857C5C@sourceware.org> Date: Mon, 17 Oct 2022 23:24:31 +0000 (GMT) List-Id: https://gcc.gnu.org/g:43ee3f64cb519f2675fa1771007d4aa3baba944f commit r13-3344-g43ee3f64cb519f2675fa1771007d4aa3baba944f Author: Jeff Law Date: Mon Oct 17 19:19:25 2022 -0400 Add missing splitter for H8 While testing a minor optimization on the H8 my builds failed due to failure to split a zero-extended memory load. That particular pattern is a bit special on the H8 in that it's split at assembly time primarily to get the length computations correct. Arguably that alternative should go away completely, but I haven't really looked into that. Anyway, with the final-asm split we obviously need to match a define_split somewhere. But none was ever written after adding CCZN optimizations. So if we had a zero extend of a memory operand and it was used to eliminate a compare, then we'd abort at final asm time. Regression tested (in conjunction with various other in-progress patches) on H8 without regressions. gcc/ * config/h8300/extensions.md (CCZN setting zero extended load): Add missing splitter. Diff: --- gcc/config/h8300/extensions.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/gcc/config/h8300/extensions.md b/gcc/config/h8300/extensions.md index 74647c79cd8..7149dc0ac52 100644 --- a/gcc/config/h8300/extensions.md +++ b/gcc/config/h8300/extensions.md @@ -47,6 +47,24 @@ operands[2] = gen_rtx_REG (QImode, REGNO (operands[0])); }) +;; Similarly, but setting cczn. +(define_split + [(set (reg:CCZN CC_REG) + (compare:CCZN + (zero_extend:HI (match_operand:QI 1 "general_operand_src" "")) + (const_int 0))) + (set (match_operand:HI 0 "register_operand" "") + (zero_extend:HI (match_dup 1)))] + "!REG_P (operands[1]) && reload_completed" + [(parallel [(set (match_dup 2) (match_dup 1)) + (clobber (reg:CC CC_REG))]) + (parallel [(set (reg:CCZN CC_REG) + (compare:CCZN (zero_extend:HI (match_dup 2)) (const_int 0))) + (set (match_dup 0) (zero_extend:HI (match_dup 2)))])] + { + operands[2] = gen_rtx_REG (QImode, REGNO (operands[0])); + }) + (define_insn "*zero_extendqisi2" [(set (match_operand:SI 0 "register_operand" "=r,r") (zero_extend:SI (match_operand:QI 1 "general_operand_src" "0,g>")))]