public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-3357] libgcc: Quote variable in Makefile.in
Date: Tue, 18 Oct 2022 11:12:13 +0000 (GMT)	[thread overview]
Message-ID: <20221018111213.714CB3858C50@sourceware.org> (raw)

https://gcc.gnu.org/g:e73fe9e162af7b875a54cd78ddbb6bf26d8b06c2

commit r13-3357-ge73fe9e162af7b875a54cd78ddbb6bf26d8b06c2
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Oct 12 12:35:00 2022 +0100

    libgcc: Quote variable in Makefile.in
    
    If the xgcc executable has not been built (or has been removed by 'make
    clean') then the command to print the multilib dir fails, and so the
    MULTIOSDIR variable is empty. That then causes:
    /bin/sh: line 0: test: !=: unary operator expected
    
    We can avoid it by quoting the variable.
    
    libgcc/ChangeLog:
    
            * Makefile.in: Quote variable.

Diff:
---
 libgcc/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libgcc/Makefile.in b/libgcc/Makefile.in
index 1fe708a93f7..6e2a0470944 100644
--- a/libgcc/Makefile.in
+++ b/libgcc/Makefile.in
@@ -310,7 +310,7 @@ CRTSTUFF_T_CFLAGS =
 MULTIDIR := $(shell $(CC) $(CFLAGS) -print-multi-directory)
 MULTIOSDIR := $(shell $(CC) $(CFLAGS) -print-multi-os-directory)
 
-MULTIOSSUBDIR := $(shell if test $(MULTIOSDIR) != .; then echo /$(MULTIOSDIR); fi)
+MULTIOSSUBDIR := $(shell if test "$(MULTIOSDIR)" != .; then echo /$(MULTIOSDIR); fi)
 inst_libdir = $(libsubdir)$(MULTISUBDIR)
 inst_slibdir = $(slibdir)$(MULTIOSSUBDIR)

                 reply	other threads:[~2022-10-18 11:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221018111213.714CB3858C50@sourceware.org \
    --to=redi@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).