From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2063) id 3CE34385E02D; Thu, 20 Oct 2022 02:16:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3CE34385E02D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1666232205; bh=oa5PA1UzNDiunaSxHsQEA3fSuZVfldbdkvFxND2xdqQ=; h=From:To:Subject:Date:From; b=HoqSfaAye5j5yAvwVE9+b4in2mCm+Ai4WLMpWwnQEBhy3kVR1bKIgSTwZ0wpTJvAi +d+dbldPFcel+EjXwGlQOvlE8rCErvRIN8uv6HyV7awOOit7VBCALZufYtEKYhq6e+ K5z1FuTgPWDOZK852WAaiFQUOTeLrqwYRaONpPjI= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Kewen Lin To: gcc-cvs@gcc.gnu.org Subject: [gcc r10-11047] rs6000: Fix the condition with frame_pointer_needed_indeed [PR96072] X-Act-Checkin: gcc X-Git-Author: Kewen Lin X-Git-Refname: refs/heads/releases/gcc-10 X-Git-Oldrev: b7289ec1f4b9cf089792e9bed966072dbf19d72e X-Git-Newrev: fa38c8b46eec550aee7e561c5b4b7c01a4ef42e3 Message-Id: <20221020021645.3CE34385E02D@sourceware.org> Date: Thu, 20 Oct 2022 02:16:44 +0000 (GMT) List-Id: https://gcc.gnu.org/g:fa38c8b46eec550aee7e561c5b4b7c01a4ef42e3 commit r10-11047-gfa38c8b46eec550aee7e561c5b4b7c01a4ef42e3 Author: Kewen Lin Date: Mon Sep 26 00:33:18 2022 -0500 rs6000: Fix the condition with frame_pointer_needed_indeed [PR96072] As PR96072 shows, the code adding REG_CFA_DEF_CFA reg note makes one assumption that we have emitted one insn which restores the frame pointer previously. That part of code was guarded with flag frame_pointer_needed before, it was consistent, but it was replaced with flag frame_pointer_needed_indeed since commit r10-7981. It caused ICE due to unexpected NULL insn. PR target/96072 gcc/ChangeLog: * config/rs6000/rs6000-logue.c (rs6000_emit_epilogue): Update the condition for adding REG_CFA_DEF_CFA reg note with frame_pointer_needed_indeed. gcc/testsuite/ChangeLog: * gcc.target/powerpc/pr96072.c: New test. (cherry picked from commit 5be0950d22209f5ba69d244387228e12389a8470) Diff: --- gcc/config/rs6000/rs6000-logue.c | 2 +- gcc/testsuite/gcc.target/powerpc/pr96072.c | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/gcc/config/rs6000/rs6000-logue.c b/gcc/config/rs6000/rs6000-logue.c index fbde3b62f48..ebfc3ff868f 100644 --- a/gcc/config/rs6000/rs6000-logue.c +++ b/gcc/config/rs6000/rs6000-logue.c @@ -4885,7 +4885,7 @@ rs6000_emit_epilogue (enum epilogue_type epilogue_type) a REG_CFA_DEF_CFA note, but that's OK; A duplicate is discarded by dwarf2cfi.c/dwarf2out.c, and in any case would be harmless if emitted. */ - if (frame_pointer_needed) + if (frame_pointer_needed_indeed) { insn = get_last_insn (); add_reg_note (insn, REG_CFA_DEF_CFA, diff --git a/gcc/testsuite/gcc.target/powerpc/pr96072.c b/gcc/testsuite/gcc.target/powerpc/pr96072.c new file mode 100644 index 00000000000..10341c91d2f --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr96072.c @@ -0,0 +1,14 @@ +/* { dg-options "-O2" } */ + +/* This used to ICE with the SYSV ABI (PR96072). */ + +void +he (int jn) +{ + { + int bh[jn]; + if (jn != 0) + goto wa; + } +wa:; +}