public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-3428] Don't build readline/libreadline.a, when --with-system-readline is supplied
Date: Fri, 21 Oct 2022 06:52:13 +0000 (GMT)	[thread overview]
Message-ID: <20221021065213.D1E6D3858D39@sourceware.org> (raw)

https://gcc.gnu.org/g:36ba985145ffa8e2078033fc1f1cf22851707a8e

commit r13-3428-g36ba985145ffa8e2078033fc1f1cf22851707a8e
Author: Дилян Палаузов <dilyan.palauzov@aegee.org>
Date:   Thu Oct 20 17:05:04 2022 +0200

    Don't build readline/libreadline.a, when --with-system-readline is supplied
    
    https://sourceware.org/bugzilla/show_bug.cgi?id=18632
    
    The bundled libreadline is always built, even if the system is
    ./configure'd --with-system-readline and the build libreadline.a is not
    used.
    
    Proposed patch:
    
    Fix ./configure.ac not to proceed readline/, when --with-system-
    readline is provided
    
            * configure.ac: Don't configure readline if --with-system-readline is
            used.
            * configure: Re-generate.

Diff:
---
 configure    | 6 ++++++
 configure.ac | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/configure b/configure
index d9aa84c6138..007a77a5f6c 100755
--- a/configure
+++ b/configure
@@ -2946,6 +2946,12 @@ if test x$with_system_zlib = xyes ; then
   noconfigdirs="$noconfigdirs zlib"
 fi
 
+# Don't compile the bundled readline/libreadline.a if --with-system-readline
+# is provided.
+if test x$with_system_readline = xyes ; then
+  noconfigdirs="$noconfigdirs readline"
+fi
+
 # some tools are so dependent upon X11 that if we're not building with X,
 # it's not even worth trying to configure, much less build, that tool.
 
diff --git a/configure.ac b/configure.ac
index 2cff32e300e..1df410bba1f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -247,6 +247,12 @@ if test x$with_system_zlib = xyes ; then
   noconfigdirs="$noconfigdirs zlib"
 fi
 
+# Don't compile the bundled readline/libreadline.a if --with-system-readline
+# is provided.
+if test x$with_system_readline = xyes ; then
+  noconfigdirs="$noconfigdirs readline"
+fi
+
 # some tools are so dependent upon X11 that if we're not building with X, 
 # it's not even worth trying to configure, much less build, that tool.

                 reply	other threads:[~2022-10-21  6:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221021065213.D1E6D3858D39@sourceware.org \
    --to=vries@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).