public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-3443] Update selftest such that [-Inf, +Inf] is always VARYING for -ffinite-math-only.
Date: Sat, 22 Oct 2022 14:26:25 +0000 (GMT)	[thread overview]
Message-ID: <20221022142626.60B0B3858285@sourceware.org> (raw)

https://gcc.gnu.org/g:423df44a090846b9c59650efb11745f07914f1d5

commit r13-3443-g423df44a090846b9c59650efb11745f07914f1d5
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Sat Oct 22 16:22:50 2022 +0200

    Update selftest such that [-Inf, +Inf] is always VARYING for -ffinite-math-only.
    
    [-Inf, +Inf] +-NAN gets normalized as VARYING.  There is a test that
    drops the NAN possibility, and tests that the range is no longer
    VARYING but [-Inf, +Inf].  However, for -ffinite-math-only targets
    (Vax, RX, etc) the range would still be VARYING because the VARYING
    range never had a NAN to begin with.  This fixes the test.
    
    I have a precommit hook that does self-tests with
    -fno-finite-math-only, -ffinite-math-only, and -ffast-math as a sanity
    check, but my precommit hook last week was disabled because there was
    a tree-ssa.exp in mainline failing which was throwing off my scripts.
    My apologies.
    
    gcc/ChangeLog:
    
            * value-range.cc (range_tests_floats): Predicate [-Inf, +Inf] test
            with !flag_finite_math_only.

Diff:
---
 gcc/value-range.cc | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gcc/value-range.cc b/gcc/value-range.cc
index bcda4987307..d779e9819e2 100644
--- a/gcc/value-range.cc
+++ b/gcc/value-range.cc
@@ -3960,8 +3960,11 @@ range_tests_floats ()
   if (r0.maybe_isnan ())
     ASSERT_TRUE (r0.varying_p ());
   // ...unless it has some special property...
-  r0.clear_nan ();
-  ASSERT_FALSE (r0.varying_p ());
+  if (!flag_finite_math_only)
+    {
+      r0.clear_nan ();
+      ASSERT_FALSE (r0.varying_p ());
+    }
 
   // For most architectures, where float and double are different
   // sizes, having the same endpoints does not necessarily mean the

                 reply	other threads:[~2022-10-22 14:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221022142626.60B0B3858285@sourceware.org \
    --to=aldyh@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).