From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1534) id EBECD38582B4; Mon, 24 Oct 2022 20:00:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EBECD38582B4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1666641611; bh=WWu4m6W4/wdwqZ9kIePITrQMoMmoUOGiiejDV/SS9CA=; h=From:To:Subject:Date:From; b=KuX+metFX92H16WnFDEwFlu8y+P9RnThKpsyDiOgY914VIN/ssgMMiMFh47JM3ArP pIxdJaTi+M+fMolnGdJSiK/CqPXmTG8NDDDLPkBqXmuLDEOfwYi1jvcLy1yRy5tFXX VVga57I4rsBCImwGvijoDM6pcTMJg23xkIod1ctM= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Tobias Burnus To: gcc-cvs@gcc.gnu.org Subject: [gcc/devel/omp/gcc-12] libgomp/nvptx: Prepare for reverse-offload callback handling, resolve spurious SIGSEGVs X-Act-Checkin: gcc X-Git-Author: Thomas Schwinge X-Git-Refname: refs/heads/devel/omp/gcc-12 X-Git-Oldrev: 2a0dc45c854448ec4628dab5c6c08999a5cf3fe5 X-Git-Newrev: e0322c67969405001d39cf5bb40ddf545b630779 Message-Id: <20221024200011.EBECD38582B4@sourceware.org> Date: Mon, 24 Oct 2022 20:00:11 +0000 (GMT) List-Id: https://gcc.gnu.org/g:e0322c67969405001d39cf5bb40ddf545b630779 commit e0322c67969405001d39cf5bb40ddf545b630779 Author: Thomas Schwinge Date: Mon Oct 24 21:59:37 2022 +0200 libgomp/nvptx: Prepare for reverse-offload callback handling, resolve spurious SIGSEGVs Per commit r13-3460-g131d18e928a3ea1ab2d3bf61aa92d68a8a254609 "libgomp/nvptx: Prepare for reverse-offload callback handling", I'm seeing a lot of libgomp execution test regressions. Random example, 'libgomp.c-c++-common/error-1.c': [...] GOMP_OFFLOAD_run: kernel main$_omp_fn$0: launch [(teams: 1), 1, 1] [(lanes: 32), (threads: 8), 1] Thread 1 "a.out" received signal SIGSEGV, Segmentation fault. 0x00007ffff793b87d in GOMP_OFFLOAD_run (ord=, tgt_fn=, tgt_vars=, args=) at [...]/source-gcc/libgomp/plugin/plugin-nvptx.c:2127 2127 if (__atomic_load_n (&ptx_dev->rev_data->fn, __ATOMIC_ACQUIRE) != 0) (gdb) print ptx_dev $1 = (struct ptx_device *) 0x6a55a0 (gdb) print ptx_dev->rev_data $2 = (struct rev_offload *) 0xffffffff00000000 (gdb) print ptx_dev->rev_data->fn Cannot access memory at address 0xffffffff00000000 libgomp/ * plugin/plugin-nvptx.c (nvptx_open_device): Initialize 'ptx_dev->rev_data'. (cherry picked from commit 205538832b7033699047900cf25928f5920d8b93) Diff: --- libgomp/ChangeLog.omp | 8 ++++++++ libgomp/plugin/plugin-nvptx.c | 2 ++ 2 files changed, 10 insertions(+) diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp index ab340385c83..ee0f09ead13 100644 --- a/libgomp/ChangeLog.omp +++ b/libgomp/ChangeLog.omp @@ -1,3 +1,11 @@ +2022-10-24 Tobias Burnus + + Backport from mainline: + 2022-10-24 Thomas Schwinge + + * plugin/plugin-nvptx.c (nvptx_open_device): Initialize + 'ptx_dev->rev_data'. + 2022-10-24 Tobias Burnus Backport from mainline: diff --git a/libgomp/plugin/plugin-nvptx.c b/libgomp/plugin/plugin-nvptx.c index 1bf22bc17a0..be3af6cea2a 100644 --- a/libgomp/plugin/plugin-nvptx.c +++ b/libgomp/plugin/plugin-nvptx.c @@ -560,6 +560,8 @@ nvptx_open_device (int n) ptx_dev->omp_stacks.size = 0; pthread_mutex_init (&ptx_dev->omp_stacks.lock, NULL); + ptx_dev->rev_data = NULL; + return ptx_dev; }