public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Kito Cheng <kito@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-3506] RISC-V: Fix epilogue generation for barrier.
Date: Wed, 26 Oct 2022 09:05:52 +0000 (GMT)	[thread overview]
Message-ID: <20221026090557.2064C385828E@sourceware.org> (raw)

https://gcc.gnu.org/g:4329d111f48cba9ea560fc0a36f4cb5a290decb2

commit r13-3506-g4329d111f48cba9ea560fc0a36f4cb5a290decb2
Author: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
Date:   Tue Oct 25 21:53:23 2022 +0800

    RISC-V: Fix epilogue generation for barrier.
    
     I noticed that I have made a mistake in previous patch:
     https://patchwork.sourceware.org/project/gcc/patch/20220817071950.271762-1-juzhe.zhong@rivai.ai/
    
     The previous statement before this patch:
     bool need_barrier_p = (get_frame_size () + cfun->machine->frame.arg_pointer_offset) != 0;
    
     However, I changed it in the previous patch:
     bool need_barrier_p = known_ne (get_frame_size (), cfun->machine->frame.arg_pointer_offset);
     This is incorrect.
    
     Now, I correct this statement in this patch.
    
    gcc/ChangeLog:
    
            * config/riscv/riscv.cc (riscv_expand_epilogue): Fix statement.

Diff:
---
 gcc/config/riscv/riscv.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index fac8def31d8..3d02954ffce 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -5025,8 +5025,8 @@ riscv_expand_epilogue (int style)
   rtx insn;
 
   /* We need to add memory barrier to prevent read from deallocated stack.  */
-  bool need_barrier_p
-    = known_ne (get_frame_size (), cfun->machine->frame.arg_pointer_offset);
+  bool need_barrier_p = known_ne (get_frame_size ()
+				  + cfun->machine->frame.arg_pointer_offset, 0);
 
   if (cfun->machine->naked_p)
     {

                 reply	other threads:[~2022-10-26  9:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221026090557.2064C385828E@sourceware.org \
    --to=kito@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).