From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1971) id 88A53385D0C0; Fri, 28 Oct 2022 14:09:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 88A53385D0C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1666966147; bh=UEWLKAphYn6JcX8XiR2MlB+Yi5QkOhe+ZqvJc5C/JxU=; h=From:To:Subject:Date:From; b=TivgrpVmeVM+EYLuhtqyeIEHJ11xW3yqpEIX7gXLtcaDjuMlJb9Vt2AOu1xdhSK+Z LSyUAXp61KYoo5BLojNUzzJYeHQcCNKve9cuCZy5yht83jshseCf1NGMIiFez6wqlW sMcQNtJdoP+qC7vuTVS/Rqlcq3BZ/eR99CbW9B7Y= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andre Simoes Dias Vieira To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-3547] vect: Reject non-byte offsets for gather/scatters [PR107346] X-Act-Checkin: gcc X-Git-Author: Andre Vieira X-Git-Refname: refs/heads/master X-Git-Oldrev: 031a400e49d8db156c43f9ec0b21ab0c2aee8c6d X-Git-Newrev: 95decac3ce8c8c7c5302cd6fac005a10463de165 Message-Id: <20221028140907.88A53385D0C0@sourceware.org> Date: Fri, 28 Oct 2022 14:09:05 +0000 (GMT) List-Id: https://gcc.gnu.org/g:95decac3ce8c8c7c5302cd6fac005a10463de165 commit r13-3547-g95decac3ce8c8c7c5302cd6fac005a10463de165 Author: Andre Vieira Date: Fri Oct 28 15:05:11 2022 +0100 vect: Reject non-byte offsets for gather/scatters [PR107346] The ada failure reported in the PR was being caused by vect_check_gather_scatter failing to deal with bit offsets that weren't multiples of BITS_PER_UNIT. This patch makes vect_check_gather_scatter reject memory accesses with such offsets. gcc/ChangeLog: PR tree-optimization/107346 * tree-vect-data-refs.cc (vect_check_gather_scatter): Reject offsets that aren't multiples of BITS_PER_UNIT. Diff: --- gcc/tree-vect-data-refs.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gcc/tree-vect-data-refs.cc b/gcc/tree-vect-data-refs.cc index 4a23d6172aa..6c892791bd4 100644 --- a/gcc/tree-vect-data-refs.cc +++ b/gcc/tree-vect-data-refs.cc @@ -4016,6 +4016,11 @@ vect_check_gather_scatter (stmt_vec_info stmt_info, loop_vec_info loop_vinfo, if (reversep) return false; + /* PR 107346. Packed structs can have fields at offsets that are not + multiples of BITS_PER_UNIT. Do not use gather/scatters in such cases. */ + if (!multiple_p (pbitpos, BITS_PER_UNIT)) + return false; + poly_int64 pbytepos = exact_div (pbitpos, BITS_PER_UNIT); if (TREE_CODE (base) == MEM_REF)