From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1472) id D63083858D26; Sun, 6 Nov 2022 00:53:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D63083858D26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1667696007; bh=4c1WV2quLKFZgceAkH3J6ySJ3pPnE3orQs+sbTQoX5Q=; h=From:To:Subject:Date:From; b=trUZIbSnYRMIOaQTegodL3MJglq8sF6uPV0TVekJ0cLGy8BWtyZsABm+b9dc5mBpq bS0eYLqVlhhE0Yen/ZU9QrXYBtDHzpSxibbV4ooCA20TtMs6KoahqGfOjldRiWrtBp 2JXuDET23MtayqfouKkfDFJ7h8rna9ampHAVaVaY= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Bernhard Reutner-Fischer To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-3701] Plug memory leak in attribute target_clones X-Act-Checkin: gcc X-Git-Author: Bernhard Reutner-Fischer X-Git-Refname: refs/heads/master X-Git-Oldrev: efbf11e97b476d7f85a3d5c599a6c11e211362e8 X-Git-Newrev: 07b0096e5b6749d88f5a22f694401abd6aaca551 Message-Id: <20221106005327.D63083858D26@sourceware.org> Date: Sun, 6 Nov 2022 00:53:27 +0000 (GMT) List-Id: https://gcc.gnu.org/g:07b0096e5b6749d88f5a22f694401abd6aaca551 commit r13-3701-g07b0096e5b6749d88f5a22f694401abd6aaca551 Author: Bernhard Reutner-Fischer Date: Thu Nov 3 21:52:51 2022 +0100 Plug memory leak in attribute target_clones It looks like there was some memory leak in the handling of attribute target_clones. Ok for trunk if testing passes? gcc/ChangeLog: * multiple_target.cc (expand_target_clones): Free memory. Signed-off-by: Bernhard Reutner-Fischer Diff: --- gcc/multiple_target.cc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/gcc/multiple_target.cc b/gcc/multiple_target.cc index 67866a7c963..77e0f21dd05 100644 --- a/gcc/multiple_target.cc +++ b/gcc/multiple_target.cc @@ -390,19 +390,23 @@ expand_target_clones (struct cgraph_node *node, bool definition) for (i = 0; i < attrnum; i++) { char *attr = attrs[i]; - char *suffix = XNEWVEC (char, strlen (attr) + 1); - create_new_asm_name (attr, suffix); /* Create new target clone. */ tree attributes = make_attribute ("target", attr, DECL_ATTRIBUTES (node->decl)); + char *suffix = XNEWVEC (char, strlen (attr) + 1); + create_new_asm_name (attr, suffix); cgraph_node *new_node = create_target_clone (node, definition, suffix, attributes); + XDELETEVEC (suffix); if (new_node == NULL) - return false; + { + XDELETEVEC (attrs); + XDELETEVEC (attr_str); + return false; + } new_node->local = false; - XDELETEVEC (suffix); decl2_v = new_node->function_version (); if (decl2_v != NULL)