From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7871) id 060A9385840A; Mon, 7 Nov 2022 08:38:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 060A9385840A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1667810322; bh=IQOxOj5tuj0qKTcG2DD9aTkU30sQhoQrdiGfKjKW7Z4=; h=From:To:Subject:Date:From; b=tPKHb59o1vMvAm8DomlbG/HWMKTnMumnSSdSn9W5N1anVDnI73YNOyJJWIlFKNj4/ xF4ccfgtPDpjJvLhBTretyZY2gyjR/79dO/F4oVDU1R6aIQ2ItfE3g6e4rl8gXNmcr gH/6PrYCLtmx1RqjRy6RMY5LjZ0m10473Kp1/uVQ= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Marc Poulhi?s To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-3726] ada: Cleanup comment about mapping parameters when inlining X-Act-Checkin: gcc X-Git-Author: Piotr Trojanek X-Git-Refname: refs/heads/master X-Git-Oldrev: 748976cfc867cb387f0f8180c48233e883223f93 X-Git-Newrev: 76b35e7227f34e2ce18e50ca637c86d7a1c3ef49 Message-Id: <20221107083842.060A9385840A@sourceware.org> Date: Mon, 7 Nov 2022 08:38:42 +0000 (GMT) List-Id: https://gcc.gnu.org/g:76b35e7227f34e2ce18e50ca637c86d7a1c3ef49 commit r13-3726-g76b35e7227f34e2ce18e50ca637c86d7a1c3ef49 Author: Piotr Trojanek Date: Fri Aug 12 11:51:30 2022 +0200 ada: Cleanup comment about mapping parameters when inlining Improve location of the comment about a special case for GNATprove mode. gcc/ada/ * inline.adb (Establish_Actual_Mapping_For_Inlined_Call): Move comment next to a condition that it describes. Diff: --- gcc/ada/inline.adb | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/gcc/ada/inline.adb b/gcc/ada/inline.adb index e3f35daca09..a1ead98e67a 100644 --- a/gcc/ada/inline.adb +++ b/gcc/ada/inline.adb @@ -3013,14 +3013,10 @@ package body Inline is Temp_Typ := Etype (A); end if; - -- If the actual is a simple name or a literal, no need to - -- create a temporary, object can be used directly. - - -- If the actual is a literal and the formal has its address taken, - -- we cannot pass the literal itself as an argument, so its value - -- must be captured in a temporary. Skip this optimization in - -- GNATprove mode, to make sure any check on a type conversion - -- will be issued. + -- If the actual is a simple name or a literal, no need to create a + -- temporary, object can be used directly. Skip this optimization in + -- GNATprove mode, to make sure any check on a type conversion will + -- be issued. if (Is_Entity_Name (A) and then @@ -3039,6 +3035,10 @@ package body Inline is and then Formal_Is_Used_Once (F) and then not GNATprove_Mode) + -- If the actual is a literal and the formal has its address taken, + -- we cannot pass the literal itself as an argument, so its value + -- must be captured in a temporary. + or else (Nkind (A) in N_Real_Literal | N_Integer_Literal | N_Character_Literal