public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: hongtao Liu <liuhongt@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-3821] Fix incorrect insn type to avoid ICE in memory attr auto-detection.
Date: Wed,  9 Nov 2022 01:13:17 +0000 (GMT)	[thread overview]
Message-ID: <20221109011317.F1A8B3858014@sourceware.org> (raw)

https://gcc.gnu.org/g:916bec9a05ea522c81381e0c93590d46965d9c7b

commit r13-3821-g916bec9a05ea522c81381e0c93590d46965d9c7b
Author: liuhongt <hongtao.liu@intel.com>
Date:   Mon Nov 7 09:55:25 2022 +0800

    Fix incorrect insn type to avoid ICE in memory attr auto-detection.
    
    Memory attribute auto detection will check operand 2 for type sselog,
    and check operand 1 for type sselog1. For below 2 insns, there's no
    operand 2. Change type to sselog1.
    
    gcc/ChangeLog:
    
            PR target/107540
            * config/i386/sse.md (avx512f_movddup512<mask_name>): Change
            type from sselog to sselog1.
            (avx_movddup256<mask_name>): Ditto.
    
    gcc/testsuite/ChangeLog:
    
            * gcc.target/i386/pr107540.c: New test.

Diff:
---
 gcc/config/i386/sse.md                   |  4 ++--
 gcc/testsuite/gcc.target/i386/pr107540.c | 12 ++++++++++++
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
index 9a4fc01856d..de632b2d8fe 100644
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -12203,7 +12203,7 @@
 		     (const_int 6) (const_int 14)])))]
   "TARGET_AVX512F"
   "vmovddup\t{%1, %0<mask_operand2>|%0<mask_operand2>, %1}"
-  [(set_attr "type" "sselog")
+  [(set_attr "type" "sselog1")
    (set_attr "prefix" "evex")
    (set_attr "mode" "V8DF")])
 
@@ -12234,7 +12234,7 @@
 		     (const_int 2) (const_int 6)])))]
   "TARGET_AVX && <mask_avx512vl_condition>"
   "vmovddup\t{%1, %0<mask_operand2>|%0<mask_operand2>, %1}"
-  [(set_attr "type" "sselog")
+  [(set_attr "type" "sselog1")
    (set_attr "prefix" "<mask_prefix>")
    (set_attr "mode" "V4DF")])
 
diff --git a/gcc/testsuite/gcc.target/i386/pr107540.c b/gcc/testsuite/gcc.target/i386/pr107540.c
new file mode 100644
index 00000000000..a0351ff9cb5
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr107540.c
@@ -0,0 +1,12 @@
+/* { dg-do compile } */
+/* { dg-options "-flive-range-shrinkage -mavx" } */
+
+typedef double __attribute__((__vector_size__ (32))) V;
+
+V v;
+
+void
+foo (void)
+{
+  v = __builtin_ia32_movddup256 (v);
+}

                 reply	other threads:[~2022-11-09  1:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221109011317.F1A8B3858014@sourceware.org \
    --to=liuhongt@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).