From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id C852D3858D35; Thu, 10 Nov 2022 10:48:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C852D3858D35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668077296; bh=4iZ6bTjdyZ+LbWiPpOr/YKMBp/x+S0bmkHRBimOo25g=; h=From:To:Subject:Date:From; b=A0MBZ24T4x90EMOP1zziFdjHb+2Ur3B2rg912ObU3l5c7j1XgFmumdI5n34b7D2X9 i0/XhoUR4LAk1jFeRevSum2d8m8znUfOUmpRlVFDr/5PSY6df71zM9XjBBJZYqdknA ROU1S4XXd1gV5lhq6R7Ao81qxnIbc4vCTQ+i14Eg= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-3874] i386: Fix up ix86_expand_int_sse_cmp [PR107585] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/master X-Git-Oldrev: 9072763f4f17e600a980ff510b2baf8ad8ada1b5 X-Git-Newrev: 49de156a6adb50e0624479f22c20141cadef812d Message-Id: <20221110104816.C852D3858D35@sourceware.org> Date: Thu, 10 Nov 2022 10:48:16 +0000 (GMT) List-Id: https://gcc.gnu.org/g:49de156a6adb50e0624479f22c20141cadef812d commit r13-3874-g49de156a6adb50e0624479f22c20141cadef812d Author: Jakub Jelinek Date: Thu Nov 10 11:46:52 2022 +0100 i386: Fix up ix86_expand_int_sse_cmp [PR107585] The following patch fixes ICE on the testcase. I've used GEN_INT incorrectly thinking the code punts on the problematic boundaries. It does, but only for LE and GE, i.e. signed comparisons, for unsigned the boundaries are 0 and unsigned maximum, so when say unsigned char adds one to 127 or subtracts one from 128 we need to canonicalize it. 2022-11-10 Jakub Jelinek PR target/107585 PR target/107546 * config/i386/i386-expand.cc (ix86_expand_int_sse_cmp): Use gen_int_mode rather than GEN_INT. * gcc.dg/pr107585.c: New test. Diff: --- gcc/config/i386/i386-expand.cc | 6 ++++-- gcc/testsuite/gcc.dg/pr107585.c | 13 +++++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand.cc index 9c92b07d5cd..acf9e00d490 100644 --- a/gcc/config/i386/i386-expand.cc +++ b/gcc/config/i386/i386-expand.cc @@ -4540,7 +4540,8 @@ ix86_expand_int_sse_cmp (rtx dest, enum rtx_code code, rtx cop0, rtx cop1, rtvec v = rtvec_alloc (n_elts); for (i = 0; i < n_elts; ++i) RTVEC_ELT (v, i) - = GEN_INT (INTVAL (CONST_VECTOR_ELT (cop1, i)) + 1); + = gen_int_mode (INTVAL (CONST_VECTOR_ELT (cop1, i)) + 1, + eltmode); cop1 = gen_rtx_CONST_VECTOR (mode, v); std::swap (cop0, cop1); code = code == LE ? GT : GTU; @@ -4584,7 +4585,8 @@ ix86_expand_int_sse_cmp (rtx dest, enum rtx_code code, rtx cop0, rtx cop1, rtvec v = rtvec_alloc (n_elts); for (i = 0; i < n_elts; ++i) RTVEC_ELT (v, i) - = GEN_INT (INTVAL (CONST_VECTOR_ELT (cop1, i)) - 1); + = gen_int_mode (INTVAL (CONST_VECTOR_ELT (cop1, i)) - 1, + eltmode); cop1 = gen_rtx_CONST_VECTOR (mode, v); code = code == GE ? GT : GTU; break; diff --git a/gcc/testsuite/gcc.dg/pr107585.c b/gcc/testsuite/gcc.dg/pr107585.c new file mode 100644 index 00000000000..820e04b6537 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr107585.c @@ -0,0 +1,13 @@ +/* PR target/107585 */ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +typedef unsigned char __attribute__((__vector_size__ (16))) V; +char c; +void bar (int); + +void +foo (void) +{ + bar (((V) (c <= (V){127}))[2]); +}