From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 090C9395B43F; Wed, 16 Nov 2022 16:07:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 090C9395B43F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668614878; bh=ZvGct6vIh4e2rg3ZJt+RlNPiRHXvk7RbFROtTarqfsM=; h=From:To:Subject:Date:From; b=IK5gP/6Bnuuu3L26qJijQx2ql/hjoOOPnIwuaUUoEUXWePZ+W9BJ40miX/MaL2N2w XKprCboGXn8HkkeEDRkM4fmw6KDHEiQ4XuihmmZCv7LoEmt2O0DFRolQ+SHdWEv3F+ l7APAHdVN+LsiJUDNtNiShLJlEzhH9294Fs29Wsc= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-4101] middle-end/107679 - fix SSA rewrite of clobber of parameter X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: 7026d0455dce1092975d4884f450a12a6ed205c7 X-Git-Newrev: 8a5f3663f8de45b7030dfe7ce962783dc1a19885 Message-Id: <20221116160758.090C9395B43F@sourceware.org> Date: Wed, 16 Nov 2022 16:07:58 +0000 (GMT) List-Id: https://gcc.gnu.org/g:8a5f3663f8de45b7030dfe7ce962783dc1a19885 commit r13-4101-g8a5f3663f8de45b7030dfe7ce962783dc1a19885 Author: Richard Biener Date: Wed Nov 16 13:57:14 2022 +0100 middle-end/107679 - fix SSA rewrite of clobber of parameter When the frontend clobbers a parameter and that parameter gets rewritten into SSA then we ICE because we didn't expect this. Avoid using the parameter decl to create a SSA default def in this case. PR middle-end/107679 * tree-into-ssa.cc (maybe_register_def): Use new temporary if we require an uninitialized value for a parameter decl. * gfortran.dg/pr107679.f90: New testcase. Diff: --- gcc/testsuite/gfortran.dg/pr107679.f90 | 9 +++++++++ gcc/tree-into-ssa.cc | 8 ++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gfortran.dg/pr107679.f90 b/gcc/testsuite/gfortran.dg/pr107679.f90 new file mode 100644 index 00000000000..33a52fb5ef2 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr107679.f90 @@ -0,0 +1,9 @@ +! { dg-do compile } + +subroutine s1(x) + integer, intent(out) :: x +end +subroutine s2(z) + integer, value :: z + call s1(z) +end diff --git a/gcc/tree-into-ssa.cc b/gcc/tree-into-ssa.cc index d13fb720b37..f21ed2bea3f 100644 --- a/gcc/tree-into-ssa.cc +++ b/gcc/tree-into-ssa.cc @@ -1911,13 +1911,17 @@ maybe_register_def (def_operand_p def_p, gimple *stmt, { if (gimple_clobber_p (stmt) && is_gimple_reg (sym)) { - gcc_checking_assert (VAR_P (sym)); + tree defvar; + if (VAR_P (sym)) + defvar = sym; + else + defvar = create_tmp_reg (TREE_TYPE (sym)); /* Replace clobber stmts with a default def. This new use of a default definition may make it look like SSA_NAMEs have conflicting lifetimes, so we need special code to let them coalesce properly. */ to_delete = true; - def = get_or_create_ssa_default_def (cfun, sym); + def = get_or_create_ssa_default_def (cfun, defvar); } else {