From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 599A1395B438; Wed, 16 Nov 2022 16:08:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 599A1395B438 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668614883; bh=v7Cwvbjs6qBZcpv47wIw/xqhXzNXIaQAtQ78qQsjiQY=; h=From:To:Subject:Date:From; b=wHqbT+uQ4F7ZYn1wobtZyow3xw8VmIJz3wkJ865Y/1DdtYk5vJOc5qOVLka6Ahywf nnSuFR7XAz8q9UiUspUlGgIdMJ+YliljqDMkS6/EpPQRKd4SFX6vH7VMRMU5pNZffY jcMa6Q1v/D5I8GcPY4VTDon402YLLGCPt13Q3Wu0= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-4102] tree-optimization/107686 - fix bitfield ref through vec_unpack optimization X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: 8a5f3663f8de45b7030dfe7ce962783dc1a19885 X-Git-Newrev: 246bbdaa5f536b7a199dda9860c473137f40d622 Message-Id: <20221116160803.599A1395B438@sourceware.org> Date: Wed, 16 Nov 2022 16:08:03 +0000 (GMT) List-Id: https://gcc.gnu.org/g:246bbdaa5f536b7a199dda9860c473137f40d622 commit r13-4102-g246bbdaa5f536b7a199dda9860c473137f40d622 Author: Richard Biener Date: Wed Nov 16 15:27:13 2022 +0100 tree-optimization/107686 - fix bitfield ref through vec_unpack optimization The following propely restricts the bitfield access to integral types when we look through VEC_UNPACK with the intent to emit a widening conversion. PR tree-optimization/107686 * tree-ssa-forwprop.cc (optimize_vector_load): Restrict VEC_UNPACK support to integral typed bitfield refs. * gcc.dg/pr107686.c: New testcase. Diff: --- gcc/testsuite/gcc.dg/pr107686.c | 16 ++++++++++++++++ gcc/tree-ssa-forwprop.cc | 6 +++++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/pr107686.c b/gcc/testsuite/gcc.dg/pr107686.c new file mode 100644 index 00000000000..2378103c555 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr107686.c @@ -0,0 +1,16 @@ +/* { dg-do compile { target { dfp && longlong64 } } } */ +/* { dg-options "-O" } */ +/* { dg-additional-options "-mavx2" { target x86_64-*-* i?86-*-* } } */ + +typedef _Decimal64 __attribute__((__vector_size__ (64))) D; +typedef __INT32_TYPE__ __attribute__((__vector_size__ (32))) U; +typedef __INT64_TYPE__ __attribute__((__vector_size__ (64))) V; + +U u; +D d; + +void +foo (void) +{ + d = d < (D) __builtin_convertvector (u, V); +} diff --git a/gcc/tree-ssa-forwprop.cc b/gcc/tree-ssa-forwprop.cc index 7c7942600ef..429f77f199c 100644 --- a/gcc/tree-ssa-forwprop.cc +++ b/gcc/tree-ssa-forwprop.cc @@ -3162,7 +3162,11 @@ optimize_vector_load (gimple_stmt_iterator *gsi) && (def == lhs || (known_eq (bit_field_size (use_rhs), def_eltsize) && constant_multiple_p (bit_field_offset (use_rhs), - def_eltsize)))) + def_eltsize) + /* We can simulate the VEC_UNPACK_{HI,LO}_EXPR + via a NOP_EXPR only for integral types. + ??? Support VEC_UNPACK_FLOAT_{HI,LO}_EXPR. */ + && INTEGRAL_TYPE_P (TREE_TYPE (use_rhs))))) { bf_stmts.safe_push (use_stmt); continue;