From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1923) id B3B64395C07A; Wed, 16 Nov 2022 20:01:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B3B64395C07A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668628866; bh=yzaVuffAgA+GilG//CUJU2NWxaliQ7n0ZOFmwhcWc0Y=; h=From:To:Subject:Date:From; b=dDjv48X42I+0z8mFDXLScC+1XzZy1zGc/s7Jaq7pnqDy9onqwswdHaQDz4rq0O30S 1vORKSkLUrEaLa1YM3TOPQqe/UPfsjjlL/QfuRgIraV/PMTiJmH6aLgO41TbdWmCh/ 1PW0dSz4MPwuktTfmRSpBJOBio+sX5BLCGPCdZc4= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Philipp Tomsich To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-4105] RISC-V: Split "(a & (1UL << bitno)) ? 0 : 1" to bext + xori X-Act-Checkin: gcc X-Git-Author: Philipp Tomsich X-Git-Refname: refs/heads/master X-Git-Oldrev: 32462550f2803aafb726b5ae20d4d95ce36dcd9c X-Git-Newrev: ac74b3f82b339569b34dc9d1330c2faf74a1c82a Message-Id: <20221116200106.B3B64395C07A@sourceware.org> Date: Wed, 16 Nov 2022 20:01:06 +0000 (GMT) List-Id: https://gcc.gnu.org/g:ac74b3f82b339569b34dc9d1330c2faf74a1c82a commit r13-4105-gac74b3f82b339569b34dc9d1330c2faf74a1c82a Author: Philipp Tomsich Date: Thu May 12 15:11:20 2022 +0200 RISC-V: Split "(a & (1UL << bitno)) ? 0 : 1" to bext + xori We avoid reassociating "(~(a >> BIT_NO)) & 1" into "((~a) >> BIT_NO) & 1" by splitting it into a zero-extraction (bext) and an xori. This both avoids burning a register on a temporary and generates a sequence that clearly captures 'extract bit, then invert bit'. This change improves the previously generated srl a0,a0,a1 not a0,a0 andi a0,a0,1 into bext a0,a0,a1 xori a0,a0,1 Signed-off-by: Philipp Tomsich gcc/ChangeLog: * config/riscv/bitmanip.md: Add split covering "(a & (1 << BIT_NO)) ? 0 : 1". gcc/testsuite/ChangeLog: * gcc.target/riscv/zbs-bext.c: Add testcases. * gcc.target/riscv/zbs-bexti.c: Add testcases. Diff: --- gcc/config/riscv/bitmanip.md | 15 +++++++++++++++ gcc/testsuite/gcc.target/riscv/zbs-bext.c | 10 ++++++++-- gcc/testsuite/gcc.target/riscv/zbs-bexti.c | 10 ++++++++-- 3 files changed, 31 insertions(+), 4 deletions(-) diff --git a/gcc/config/riscv/bitmanip.md b/gcc/config/riscv/bitmanip.md index 86cc85001c3..fb062f6eb43 100644 --- a/gcc/config/riscv/bitmanip.md +++ b/gcc/config/riscv/bitmanip.md @@ -414,3 +414,18 @@ "TARGET_ZBS && UINTVAL (operands[2]) < GET_MODE_BITSIZE (mode)" "bexti\t%0,%1,%2" [(set_attr "type" "bitmanip")]) + +;; Split for "(a & (1 << BIT_NO)) ? 0 : 1": +;; We avoid reassociating "(~(a >> BIT_NO)) & 1" into "((~a) >> BIT_NO) & 1", +;; so we don't have to use a temporary. Instead we extract the bit and then +;; invert bit 0 ("a ^ 1") only. +(define_split + [(set (match_operand:X 0 "register_operand") + (and:X (not:X (lshiftrt:X (match_operand:X 1 "register_operand") + (subreg:QI (match_operand:X 2 "register_operand") 0))) + (const_int 1)))] + "TARGET_ZBS" + [(set (match_dup 0) (zero_extract:X (match_dup 1) + (const_int 1) + (match_dup 2))) + (set (match_dup 0) (xor:X (match_dup 0) (const_int 1)))]) diff --git a/gcc/testsuite/gcc.target/riscv/zbs-bext.c b/gcc/testsuite/gcc.target/riscv/zbs-bext.c index 8de9c5a167c..a8aadb60390 100644 --- a/gcc/testsuite/gcc.target/riscv/zbs-bext.c +++ b/gcc/testsuite/gcc.target/riscv/zbs-bext.c @@ -23,16 +23,22 @@ long bext64_1(long a, char bitno) long bext64_2(long a, char bitno) { - return (a & (1UL << bitno)) ? 0 : -1; + return (a & (1UL << bitno)) ? 0 : 1; } long bext64_3(long a, char bitno) +{ + return (a & (1UL << bitno)) ? 0 : -1; +} + +long bext64_4(long a, char bitno) { return (a & (1UL << bitno)) ? -1 : 0; } /* { dg-final { scan-assembler-times "bexti\t" 1 } } */ -/* { dg-final { scan-assembler-times "bext\t" 4 } } */ +/* { dg-final { scan-assembler-times "bext\t" 5 } } */ +/* { dg-final { scan-assembler-times "xori\t|snez\t" 1 } } */ /* { dg-final { scan-assembler-times "addi\t" 1 } } */ /* { dg-final { scan-assembler-times "neg\t" 1 } } */ /* { dg-final { scan-assembler-not "andi" } } */ \ No newline at end of file diff --git a/gcc/testsuite/gcc.target/riscv/zbs-bexti.c b/gcc/testsuite/gcc.target/riscv/zbs-bexti.c index 30b69c9bc3e..c15098eb6cc 100644 --- a/gcc/testsuite/gcc.target/riscv/zbs-bexti.c +++ b/gcc/testsuite/gcc.target/riscv/zbs-bexti.c @@ -12,14 +12,20 @@ long bexti64_1(long a, char bitno) long bexti64_2(long a, char bitno) { - return (a & (1UL << BIT_NO)) ? 0 : -1; + return (a & (1UL << BIT_NO)) ? 0 : 1; } long bexti64_3(long a, char bitno) +{ + return (a & (1UL << BIT_NO)) ? 0 : -1; +} + +long bexti64_4(long a, char bitno) { return (a & (1UL << BIT_NO)) ? -1 : 0; } -/* { dg-final { scan-assembler-times "bexti\t" 3 } } */ +/* { dg-final { scan-assembler-times "bexti\t" 4 } } */ +/* { dg-final { scan-assembler-times "xori\t|snez\t" 1 } } */ /* { dg-final { scan-assembler-times "addi\t" 1 } } */ /* { dg-final { scan-assembler-times "neg\t" 1 } } */