From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1734) id D409C385456C; Fri, 18 Nov 2022 00:16:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D409C385456C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668730618; bh=Goe1+zzgsCZf17HoPXr6zPmiTuVJzfgu0JsJwWWXCNQ=; h=From:To:Subject:Date:From; b=CAI5NOfbfsS+zDSixM4vq7EaQAcEX+ykZXeZvz4ykjEhVTF0ELKRK2CXBTVoxztFm 0qvvvLc52e6YE8p+eUllUg0uc164+ZkMmzJ9DBC2rBpHetcBNnY3R+VNU4jClSEQH7 XD5mEUf515XZ/GWtehRClnuYRxelfxysoTI/w3hQ= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Marek Polacek To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-4135] c++: constinit on pointer to function [PR104066] X-Act-Checkin: gcc X-Git-Author: Marek Polacek X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 3f467ea953431aa6af12aaed6d32f476f7ace1e5 X-Git-Newrev: 7b3b2f50953c5143d4b14b59d322d8a793f411dd Message-Id: <20221118001658.D409C385456C@sourceware.org> Date: Fri, 18 Nov 2022 00:16:57 +0000 (GMT) List-Id: https://gcc.gnu.org/g:7b3b2f50953c5143d4b14b59d322d8a793f411dd commit r13-4135-g7b3b2f50953c5143d4b14b59d322d8a793f411dd Author: Marek Polacek Date: Thu Nov 17 11:59:29 2022 -0500 c++: constinit on pointer to function [PR104066] [dcl.constinit]: "The constinit specifier shall be applied only to a declaration of a variable with static or thread storage duration." Thus, this ought to be OK: constinit void (*p)() = nullptr; but the error message I introduced when implementing constinit was not looking at funcdecl_p, so the code above was rejected. Fixed thus. I'm checking constinit_p first because I think that's far more likely to be false than funcdecl_p. PR c++/104066 gcc/cp/ChangeLog: * decl.cc (grokdeclarator): Check funcdecl_p before complaining about constinit. gcc/testsuite/ChangeLog: * g++.dg/cpp2a/constinit18.C: New test. Diff: --- gcc/cp/decl.cc | 2 +- gcc/testsuite/g++.dg/cpp2a/constinit18.C | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/gcc/cp/decl.cc b/gcc/cp/decl.cc index d28889ed865..9a7b1a6c381 100644 --- a/gcc/cp/decl.cc +++ b/gcc/cp/decl.cc @@ -13071,7 +13071,7 @@ grokdeclarator (const cp_declarator *declarator, "an array", name); return error_mark_node; } - if (constinit_p) + if (constinit_p && funcdecl_p) { error_at (declspecs->locations[ds_constinit], "% on function return type is not " diff --git a/gcc/testsuite/g++.dg/cpp2a/constinit18.C b/gcc/testsuite/g++.dg/cpp2a/constinit18.C new file mode 100644 index 00000000000..51b4f0273be --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp2a/constinit18.C @@ -0,0 +1,12 @@ +// PR c++/104066 +// { dg-do compile { target c++20 } } + +constinit void (*p)() = nullptr; +constinit void (*pp)() = nullptr; +void fn(); +constinit void (&r)() = fn; + +extern constinit long (* const syscall_reexported) (long, ...); + +constinit void bad (); // { dg-error ".constinit. on function return type is not allowed" } +constinit void bad () { } // { dg-error ".constinit. on function return type is not allowed" }