From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1734) id EF29F3858431; Fri, 18 Nov 2022 00:47:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF29F3858431 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668732448; bh=EPN76WIi3R/P9OyNThAPYRmwgiPcSHzq2FfAHjGaXt0=; h=From:To:Subject:Date:From; b=ogRYB7kze2Gn+5ZzThK7nMoC/ufy7kESIShuMrpP0/Zj/x9H+Ac//yQdtt+jsrX87 Op7asufHNiLM4X5b2n+AkznZHmHlf+C6ps4LmxByiNpSwBIV3rR/L4m0D+EKl7TNoT tPhVSmzPmXQBqwiAY0l2Rb4NwejYxjFsTFDIdCjw= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Marek Polacek To: gcc-cvs@gcc.gnu.org Subject: [gcc r10-11087] c++: constinit on pointer to function [PR104066] X-Act-Checkin: gcc X-Git-Author: Marek Polacek X-Git-Refname: refs/heads/releases/gcc-10 X-Git-Oldrev: 280d1001bf2de0e4ffae639c8def866ebf3f9d05 X-Git-Newrev: b9b78b4de3c7dcc6868c4af831b2d213fda21b04 Message-Id: <20221118004728.EF29F3858431@sourceware.org> Date: Fri, 18 Nov 2022 00:47:28 +0000 (GMT) List-Id: https://gcc.gnu.org/g:b9b78b4de3c7dcc6868c4af831b2d213fda21b04 commit r10-11087-gb9b78b4de3c7dcc6868c4af831b2d213fda21b04 Author: Marek Polacek Date: Thu Nov 17 11:59:29 2022 -0500 c++: constinit on pointer to function [PR104066] [dcl.constinit]: "The constinit specifier shall be applied only to a declaration of a variable with static or thread storage duration." Thus, this ought to be OK: constinit void (*p)() = nullptr; but the error message I introduced when implementing constinit was not looking at funcdecl_p, so the code above was rejected. Fixed thus. I'm checking constinit_p first because I think that's far more likely to be false than funcdecl_p. PR c++/104066 gcc/cp/ChangeLog: * decl.c (grokdeclarator): Check funcdecl_p before complaining about constinit. gcc/testsuite/ChangeLog: * g++.dg/cpp2a/constinit18.C: New test. (cherry picked from commit 7b3b2f50953c5143d4b14b59d322d8a793f411dd) Diff: --- gcc/cp/decl.c | 2 +- gcc/testsuite/g++.dg/cpp2a/constinit18.C | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c index 38003a5a70f..6af7a97a7b9 100644 --- a/gcc/cp/decl.c +++ b/gcc/cp/decl.c @@ -12275,7 +12275,7 @@ grokdeclarator (const cp_declarator *declarator, "an array", name); return error_mark_node; } - if (constinit_p) + if (constinit_p && funcdecl_p) { error_at (declspecs->locations[ds_constinit], "% on function return type is not " diff --git a/gcc/testsuite/g++.dg/cpp2a/constinit18.C b/gcc/testsuite/g++.dg/cpp2a/constinit18.C new file mode 100644 index 00000000000..51b4f0273be --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp2a/constinit18.C @@ -0,0 +1,12 @@ +// PR c++/104066 +// { dg-do compile { target c++20 } } + +constinit void (*p)() = nullptr; +constinit void (*pp)() = nullptr; +void fn(); +constinit void (&r)() = fn; + +extern constinit long (* const syscall_reexported) (long, ...); + +constinit void bad (); // { dg-error ".constinit. on function return type is not allowed" } +constinit void bad () { } // { dg-error ".constinit. on function return type is not allowed" }