From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1923) id 437A7384F4AC; Fri, 18 Nov 2022 11:34:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 437A7384F4AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668771263; bh=ckqSYFwQEb/vQBYgfaqmN9lpkq6U+qYxJWeKa8o1zlo=; h=From:To:Subject:Date:From; b=DQBbXlA38pGGbJ+qGSuv+Tr8mAyov0rTrUqS5yazEB52mNuYFtgD1cOYD4a33Z8V+ p2pvDPSgHcW/a80cDLPKyf52uQiZcRhDKlGnfGckutIQUy8/omz8//gaQKVEoUnrtH 0Z/x01GyIHj/u3rHzuSoXpuUysvXeJyHKsygjrCU= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Philipp Tomsich To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/vendors/vrull/heads/for-upstream)] RISC-V: Optimize branches testing a bit-range or a shifted immediate X-Act-Checkin: gcc X-Git-Author: Philipp Tomsich X-Git-Refname: refs/vendors/vrull/heads/for-upstream X-Git-Oldrev: c71897ea6f9cb3d9827f4807a0647f38460fb202 X-Git-Newrev: 110d7046693aff83803f20dcb81e02b82b7644e8 Message-Id: <20221118113423.437A7384F4AC@sourceware.org> Date: Fri, 18 Nov 2022 11:34:23 +0000 (GMT) List-Id: https://gcc.gnu.org/g:110d7046693aff83803f20dcb81e02b82b7644e8 commit 110d7046693aff83803f20dcb81e02b82b7644e8 Author: Philipp Tomsich Date: Tue Oct 11 15:50:11 2022 +0200 RISC-V: Optimize branches testing a bit-range or a shifted immediate gcc/ChangeLog: * config/riscv/predicates.md (shifted_const_arith_operand): (uimm_extra_bit_operand): * config/riscv/riscv.md (*branch_shiftedarith_equals_zero): (*branch_shiftedmask_equals_zero): gcc/testsuite/ChangeLog: * gcc.target/riscv/branch-1.c: New test. Series-to: gcc-patches@gcc.gnu.org Series-cc: Palmer Dabbelt Series-cc: Vineet Gupta Series-cc: Christoph Muellner Series-cc: Kito Cheng Series-cc: Jeff Law Diff: --- gcc/config/riscv/predicates.md | 23 ++++++++++++++ gcc/config/riscv/riscv.md | 51 +++++++++++++++++++++++++++++++ gcc/testsuite/gcc.target/riscv/branch-1.c | 37 ++++++++++++++++++++++ 3 files changed, 111 insertions(+) diff --git a/gcc/config/riscv/predicates.md b/gcc/config/riscv/predicates.md index ffb3fca2ac3..d5c097e259f 100644 --- a/gcc/config/riscv/predicates.md +++ b/gcc/config/riscv/predicates.md @@ -290,3 +290,26 @@ (define_predicate "const_nottwobits_operand" (and (match_code "const_int") (match_test "popcount_hwi (~UINTVAL (op)) == 2"))) + +;; A CONST_INT operand that consists of a single run of 32 consecutive +;; set bits. +(define_predicate "consecutive_bits32_operand" + (and (match_operand 0 "consecutive_bits_operand") + (match_test "popcount_hwi (UINTVAL (op)) == 32"))) + +;; A CONST_INT operand that, if shifted down to start with its least +;; significant non-zero bit, is a SMALL_OPERAND (suitable as an +;; immediate to logical and arithmetic instructions). +(define_predicate "shifted_const_arith_operand" + (and (match_code "const_int") + (match_test "ctz_hwi (INTVAL (op)) > 0") + (match_test "SMALL_OPERAND (INTVAL (op) >> ctz_hwi (INTVAL (op)))"))) + +;; A CONST_INT operand that fits into the unsigned half of a +;; signed-immediate after the top bit has been cleared. +(define_predicate "uimm_extra_bit_operand" + (and (match_code "const_int") + (not (and (match_test "SMALL_OPERAND (INTVAL (op))") + (match_test "INTVAL (op) > 0"))) + (ior (match_test "SMALL_OPERAND (UINTVAL (op) & ~(HOST_WIDE_INT_1U << floor_log2 (UINTVAL (op))))") + (match_test "popcount_hwi (UINTVAL (op)) == 2")))) diff --git a/gcc/config/riscv/riscv.md b/gcc/config/riscv/riscv.md index 3d4a1cba096..b616c1915df 100644 --- a/gcc/config/riscv/riscv.md +++ b/gcc/config/riscv/riscv.md @@ -2216,6 +2216,57 @@ ;; Conditional branches +(define_insn_and_split "*branch_shiftedarith_equals_zero" + [(set (pc) + (if_then_else (match_operator 1 "equality_operator" + [(and:ANYI (match_operand:ANYI 2 "register_operand" "r") + (match_operand 3 "shifted_const_arith_operand" "i")) + (const_int 0)]) + (label_ref (match_operand 0 "" "")) + (pc))) + (clobber (match_scratch:ANYI 4 "=&r"))] + "INTVAL (operands[3]) >= 0 || !partial_subreg_p (operands[2])" + "#" + "&& reload_completed" + [(set (match_dup 4) (lshiftrt:ANYI (match_dup 2) (match_dup 6))) + (set (match_dup 4) (and:ANYI (match_dup 4) (match_dup 7))) + (set (pc) (if_then_else (match_op_dup 1 [(match_dup 4) (const_int 0)]) + (label_ref (match_dup 0)) (pc)))] +{ + HOST_WIDE_INT mask = INTVAL (operands[3]); + int trailing = ctz_hwi (mask); + + operands[6] = GEN_INT (trailing); + operands[7] = GEN_INT (mask >> trailing); +}) + +(define_insn_and_split "*branch_shiftedmask_equals_zero" + [(set (pc) + (if_then_else (match_operator 1 "equality_operator" + [(and:ANYI (match_operand:ANYI 2 "register_operand" "r") + (match_operand 3 "consecutive_bits_operand" "i")) + (const_int 0)]) + (label_ref (match_operand 0 "" "")) + (pc))) + (clobber (match_scratch:X 4 "=&r"))] + "(INTVAL (operands[3]) >= 0 || !partial_subreg_p (operands[2])) + && popcount_hwi (INTVAL (operands[3])) > 1 + && !SMALL_OPERAND (INTVAL (operands[3]))" + "#" + "&& reload_completed" + [(set (match_dup 4) (ashift:X (subreg:X (match_dup 2) 0) (match_dup 6))) + (set (match_dup 4) (lshiftrt:X (match_dup 4) (match_dup 7))) + (set (pc) (if_then_else (match_op_dup 1 [(match_dup 4) (const_int 0)]) + (label_ref (match_dup 0)) (pc)))] +{ + unsigned HOST_WIDE_INT mask = INTVAL (operands[3]); + int leading = clz_hwi (mask); + int trailing = ctz_hwi (mask); + + operands[6] = GEN_INT (leading); + operands[7] = GEN_INT (leading + trailing); +}) + (define_insn "*branch_equals_zero" [(set (pc) (if_then_else diff --git a/gcc/testsuite/gcc.target/riscv/branch-1.c b/gcc/testsuite/gcc.target/riscv/branch-1.c new file mode 100644 index 00000000000..b4a3a946379 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/branch-1.c @@ -0,0 +1,37 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64gc -mabi=lp64" } */ +/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-O1" } } */ + +void g(); + +void f(long long a) +{ + if (a & 0xff00) + g(); +} + +void f2(long long a) +{ + if (a & (-4ull << 3)) + g(); +} + +void f3(long long a) +{ + if (a & 0xffff00) + g(); +} + +void f4(long long a) +{ + if (a & 0x7ff800) + g(); +} + +/* { dg-final { scan-assembler-times "slli\t" 2 } } */ +/* { dg-final { scan-assembler-times "srli\t" 3 } } */ +/* { dg-final { scan-assembler-times "andi\t" 1 } } */ +/* { dg-final { scan-assembler-times "\tli\t" 1 } } */ +/* { dg-final { scan-assembler-not "addi\t" } } */ +/* { dg-final { scan-assembler-not "and\t" } } */ +