From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1923) id DFACC3853D7F; Fri, 18 Nov 2022 20:25:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DFACC3853D7F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668803123; bh=Ee9qse3oEln0kYtgzdPL30lLqQ8ycgW278WJkMvmjkY=; h=From:To:Subject:Date:From; b=vnlryz8Zhiwt+u1fnxRqCuKpACzXwGerrJNW0+ULj+MRl+A6k/w0vtdVTM9hnVkjQ aM1O8VdLJGzusnWOFm570xA3eNSQbldm8pePNzxHE3frCgVXQJHpDvb7ZoW0o6GiCT MNY3MgIPZ/694lTCddjD2/cmSDGktReSJw8JU0L0= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Philipp Tomsich To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/vendors/vrull/heads/for-upstream)] RISC-V: Implement movmisalign to enable SLP X-Act-Checkin: gcc X-Git-Author: Philipp Tomsich X-Git-Refname: refs/vendors/vrull/heads/for-upstream X-Git-Oldrev: a9926c5f054f5d3ca801c0b610703a1132866b73 X-Git-Newrev: 4139aa365b3d26a9348de4bb397b09c2687aa8c6 Message-Id: <20221118202523.DFACC3853D7F@sourceware.org> Date: Fri, 18 Nov 2022 20:25:23 +0000 (GMT) List-Id: https://gcc.gnu.org/g:4139aa365b3d26a9348de4bb397b09c2687aa8c6 commit 4139aa365b3d26a9348de4bb397b09c2687aa8c6 Author: Philipp Tomsich Date: Wed Nov 9 12:54:32 2022 +0100 RISC-V: Implement movmisalign to enable SLP The default implementation of support_vector_misalignment() checks whether movmisalign is present for the requested mode. This will be used by vect_supportable_dr_alignment() to determine whether a misaligned access of vectorized data is permissible. For RISC-V this is required to convert multiple integer data refs, such as "c[1] << 8) | c[0]" into a larger (in the example before: a halfword load) access. We conditionalize on !riscv_slow_unaligned_access_p to allow the misaligned refs, if they are not expected to be slow. This benefits both xalancbmk and blender on SPEC CPU 2017. gcc/ChangeLog: * config/riscv/riscv.md (movmisalign): Implement. gcc/testsuite/ChangeLog: * gcc.target/riscv/movmisalign-1.c: New test. * gcc.target/riscv/movmisalign-2.c: New test. * gcc.target/riscv/movmisalign-3.c: New test. Series-to: gcc-patches@gcc.gnu.org Series-cc: Palmer Dabbelt Series-cc: Vineet Gupta Series-cc: Christoph Muellner Series-cc: Kito Cheng Series-cc: Jeff Law Diff: --- gcc/config/riscv/riscv.md | 18 ++++++++++++++++++ gcc/testsuite/gcc.target/riscv/movmisalign-1.c | 12 ++++++++++++ gcc/testsuite/gcc.target/riscv/movmisalign-2.c | 12 ++++++++++++ gcc/testsuite/gcc.target/riscv/movmisalign-3.c | 12 ++++++++++++ 4 files changed, 54 insertions(+) diff --git a/gcc/config/riscv/riscv.md b/gcc/config/riscv/riscv.md index 20cdb7ecfe0..5e659148403 100644 --- a/gcc/config/riscv/riscv.md +++ b/gcc/config/riscv/riscv.md @@ -1721,6 +1721,24 @@ MAX_MACHINE_MODE, &operands[3], TRUE); }) +;; Misaligned (integer) moves: provide an implementation for +;; movmisalign, so the default support_vector_misalignment() will +;; return the right boolean depending on whether +;; riscv_slow_unaligned_access_p is set or not. +;; +;; E.g., this is needed for SLP to convert "c[1] << 8) | c[0]" into a +;; HImode load (a good test case will be blender and xalancbmk in SPEC +;; CPU 2017). +;; +(define_expand "movmisalign" + [(set (match_operand:ANYI 0 "") + (match_operand:ANYI 1 ""))] + "!riscv_slow_unaligned_access_p" +{ + if (riscv_legitimize_move (mode, operands[0], operands[1])) + DONE; +}) + ;; 64-bit integer moves (define_expand "movdi" diff --git a/gcc/testsuite/gcc.target/riscv/movmisalign-1.c b/gcc/testsuite/gcc.target/riscv/movmisalign-1.c new file mode 100644 index 00000000000..791a3d63335 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/movmisalign-1.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64gc -mabi=lp64 -mtune=size" } */ +/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-O1" } } */ + +void f(unsigned short *sink, unsigned char *arr) +{ + *sink = (arr[1] << 8) | arr[0]; +} + +/* { dg-final { scan-assembler-times "lhu\t" 1 } } */ +/* { dg-final { scan-assembler-not "lbu\t" } } */ + diff --git a/gcc/testsuite/gcc.target/riscv/movmisalign-2.c b/gcc/testsuite/gcc.target/riscv/movmisalign-2.c new file mode 100644 index 00000000000..ef73dcb2d9d --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/movmisalign-2.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64gc -mabi=lp64 -mtune=size -mstrict-align" } */ +/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-O1" } } */ + +void f(unsigned short *sink, unsigned char *arr) +{ + *sink = (arr[1] << 8) | arr[0]; +} + +/* { dg-final { scan-assembler-times "lbu\t" 2 } } */ +/* { dg-final { scan-assembler-not "lhu\t" } } */ + diff --git a/gcc/testsuite/gcc.target/riscv/movmisalign-3.c b/gcc/testsuite/gcc.target/riscv/movmisalign-3.c new file mode 100644 index 00000000000..963b11c27fd --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/movmisalign-3.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64gc -mabi=lp64 -mtune=rocket" } */ +/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-O1" } } */ + +void f(unsigned short *sink, unsigned char *arr) +{ + *sink = (arr[1] << 8) | arr[0]; +} + +/* { dg-final { scan-assembler-times "lbu\t" 2 } } */ +/* { dg-final { scan-assembler-not "lhu\t" } } */ +