public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Martin Jambor <jamborm@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-4241] ipa-sra: Dump edge summaries also for non-candidates
Date: Tue, 22 Nov 2022 17:30:42 +0000 (GMT)	[thread overview]
Message-ID: <20221122173042.ACBD4385842D@sourceware.org> (raw)

https://gcc.gnu.org/g:95489a2a279893bf2e0fbb3fb378bdfcf0212faf

commit r13-4241-g95489a2a279893bf2e0fbb3fb378bdfcf0212faf
Author: Martin Jambor <mjambor@suse.cz>
Date:   Tue Nov 22 18:22:03 2022 +0100

    ipa-sra: Dump edge summaries also for non-candidates
    
    This should have been part of r12-578-g717d278af93a4a.  Call edge
    summaries provide information required for IPA-SRA transformations in
    the callees but are generated when analyzing callers and thus also
    callers which are not IPA-SRA candidates themselves.  Therefore we
    analyze them but don't dump them, which makes the dumops quite
    incomplete. This patch fixes that.
    
    gcc/ChangeLog:
    
    2021-12-14  Martin Jambor  <mjambor@suse.cz>
    
            * ipa-sra.cc (ipa_sra_dump_all_summaries): Dump edge summaries even
            for non-candidates.

Diff:
---
 gcc/ipa-sra.cc | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/gcc/ipa-sra.cc b/gcc/ipa-sra.cc
index 2237ac6d92f..718201d27fa 100644
--- a/gcc/ipa-sra.cc
+++ b/gcc/ipa-sra.cc
@@ -2805,13 +2805,10 @@ ipa_sra_dump_all_summaries (FILE *f)
       if (!ifs)
 	fprintf (f, "  Function does not have any associated IPA-SRA "
 		 "summary\n");
+      else if (!ifs->m_candidate)
+	fprintf (f, "  Not a candidate function\n");
       else
 	{
-	  if (!ifs->m_candidate)
-	    {
-	      fprintf (f, "  Not a candidate function\n");
-	      continue;
-	    }
 	  if (ifs->m_returns_value)
 	    fprintf (f, "  Returns value\n");
 	  if (vec_safe_is_empty (ifs->m_parameters))

                 reply	other threads:[~2022-11-22 17:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221122173042.ACBD4385842D@sourceware.org \
    --to=jamborm@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).