public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-4357] tree-optimization/107493 - SCEV analysis with conversions Date: Mon, 28 Nov 2022 10:17:38 +0000 (GMT) [thread overview] Message-ID: <20221128101738.E028E385B181@sourceware.org> (raw) https://gcc.gnu.org/g:2b293a949c0fbe21e47c4bc99f807dc941c02bb6 commit r13-4357-g2b293a949c0fbe21e47c4bc99f807dc941c02bb6 Author: Richard Biener <rguenther@suse.de> Date: Mon Nov 28 10:25:44 2022 +0100 tree-optimization/107493 - SCEV analysis with conversions This shows another case where trying to validate conversions during the CHREC SCC analysis fails because said analysis assumes we are converting a complete SCC. Like the constraint on the initial conversion seen restrict all conversions handled to sign-changes. PR tree-optimization/107493 * tree-scalar-evolution.cc (scev_dfs::follow_ssa_edge_expr): Only handle no-op and sign-changing conversions. * gcc.dg/torture/pr107493.c: New testcase. Diff: --- gcc/testsuite/gcc.dg/torture/pr107493.c | 13 +++++++++++++ gcc/tree-scalar-evolution.cc | 10 ++++++++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.dg/torture/pr107493.c b/gcc/testsuite/gcc.dg/torture/pr107493.c new file mode 100644 index 00000000000..b36692133d8 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr107493.c @@ -0,0 +1,13 @@ +/* { dg-do run { target int32plus } } */ + +int a; +int b(int c) { return c; } +int main() +{ + a = -21; + for (; a <= 0; a = (unsigned short)(b(a + 2) + 8)) + ; + if (a != 65525) + __builtin_abort(); + return 0; +} diff --git a/gcc/tree-scalar-evolution.cc b/gcc/tree-scalar-evolution.cc index 60060337804..f75398afb7c 100644 --- a/gcc/tree-scalar-evolution.cc +++ b/gcc/tree-scalar-evolution.cc @@ -1227,10 +1227,16 @@ scev_dfs::follow_ssa_edge_expr (gimple *at_stmt, tree expr, { CASE_CONVERT: { - /* This assignment is under the form "a_1 = (cast) rhs. */ + /* This assignment is under the form "a_1 = (cast) rhs. We cannot + validate any precision altering conversion during the SCC + analysis, so don't even try. */ + if (!tree_nop_conversion_p (type, TREE_TYPE (rhs0))) + return t_false; t_bool res = follow_ssa_edge_expr (at_stmt, rhs0, evolution_of_loop, limit); - *evolution_of_loop = chrec_convert (type, *evolution_of_loop, at_stmt); + if (res == t_true) + *evolution_of_loop = chrec_convert (type, *evolution_of_loop, + at_stmt); return res; }
reply other threads:[~2022-11-28 10:17 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221128101738.E028E385B181@sourceware.org \ --to=rguenth@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).