public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-4384] ipa/107897 - avoid property verification ICE after error
Date: Tue, 29 Nov 2022 09:25:59 +0000 (GMT)	[thread overview]
Message-ID: <20221129092559.5143038532FF@sourceware.org> (raw)

https://gcc.gnu.org/g:5894a8179687b7028d093584102d204af422cfd3

commit r13-4384-g5894a8179687b7028d093584102d204af422cfd3
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Nov 29 08:43:55 2022 +0100

    ipa/107897 - avoid property verification ICE after error
    
    The target clone pass is the only small IPA pass that doesn't disable
    itself after errors but has properties whose verification can fail
    because we cut off build SSA passes after errors.
    
            PR ipa/107897
            * multiple_target.cc (pass_target_clone::gate): Disable
            after errors.

Diff:
---
 gcc/multiple_target.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gcc/multiple_target.cc b/gcc/multiple_target.cc
index 77e0f21dd05..fd88c22b002 100644
--- a/gcc/multiple_target.cc
+++ b/gcc/multiple_target.cc
@@ -539,7 +539,8 @@ public:
 bool
 pass_target_clone::gate (function *)
 {
-  return true;
+  /* If there were any errors avoid pass property verification errors.  */
+  return !seen_error ();
 }
 
 } // anon namespace

                 reply	other threads:[~2022-11-29  9:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221129092559.5143038532FF@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).