From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1888) id E3F1F38493D1; Sun, 4 Dec 2022 15:47:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E3F1F38493D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1670168854; bh=xv5iy48i1ttBRS/5abj//21BAFmibN7e1vzTweO8Tlg=; h=From:To:Subject:Date:From; b=N1gHzovtRqA/xbpX3KmTVbZVXyvan0Yn7v+LQ5yAu+/ANznTwtbSqqFtWNhoRGp6Z fREXm/juGt7uhZgLMZjq5+3rUhUVCmfON1wA9Sali05yReLw2n4H34oVYlb5e85uV4 +jKiMieZ2MIzMWM3fEX6nIXl0S6+abEvDkJ0cVeA= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Patrick Palka To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-4483] c++: pack in requires-expr parm list [PR107417] X-Act-Checkin: gcc X-Git-Author: Patrick Palka X-Git-Refname: refs/heads/master X-Git-Oldrev: a044c9d25972b22c6b4c8ec27f2de5fd622573cc X-Git-Newrev: 079add3ad39d6620d34665dd9c26c21951eb657c Message-Id: <20221204154734.E3F1F38493D1@sourceware.org> Date: Sun, 4 Dec 2022 15:47:34 +0000 (GMT) List-Id: https://gcc.gnu.org/g:079add3ad39d6620d34665dd9c26c21951eb657c commit r13-4483-g079add3ad39d6620d34665dd9c26c21951eb657c Author: Patrick Palka Date: Sun Dec 4 10:47:24 2022 -0500 c++: pack in requires-expr parm list [PR107417] Here find_parameter_packs_r isn't detecting the pack T inside the requires-expr's parameter list ultimately because cp_walk_trees deliberately avoids walking the list so as to avoid false positives in the unexpanded pack checker. But it should still be fine to walk the TREE_TYPE of each parameter, which we already need to do from for_each_template_parm_r, and is sufficient to fix the testcase. PR c++/107417 gcc/cp/ChangeLog: * pt.cc (for_each_template_parm_r) : Move walking of the TREE_TYPE of each parameter to ... * tree.cc (cp_walk_subtrees) : ... here. gcc/testsuite/ChangeLog: * g++.dg/cpp2a/concepts-requires33.C: New test. Diff: --- gcc/cp/pt.cc | 15 --------------- gcc/cp/tree.cc | 21 ++++++++++++--------- gcc/testsuite/g++.dg/cpp2a/concepts-requires33.C | 10 ++++++++++ 3 files changed, 22 insertions(+), 24 deletions(-) diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc index bc8ea06ceae..80110da2d8a 100644 --- a/gcc/cp/pt.cc +++ b/gcc/cp/pt.cc @@ -10573,21 +10573,6 @@ for_each_template_parm_r (tree *tp, int *walk_subtrees, void *d) return error_mark_node; break; - case REQUIRES_EXPR: - { - if (!fn) - return error_mark_node; - - /* Recursively walk the type of each constraint variable. */ - tree p = TREE_OPERAND (t, 0); - while (p) - { - WALK_SUBTREE (TREE_TYPE (p)); - p = TREE_CHAIN (p); - } - } - break; - default: break; } diff --git a/gcc/cp/tree.cc b/gcc/cp/tree.cc index 04a055d9d77..33bde16f128 100644 --- a/gcc/cp/tree.cc +++ b/gcc/cp/tree.cc @@ -5603,15 +5603,18 @@ cp_walk_subtrees (tree *tp, int *walk_subtrees_p, walk_tree_fn func, break; case REQUIRES_EXPR: - // Only recurse through the nested expression. Do not - // walk the parameter list. Doing so causes false - // positives in the pack expansion checker since the - // requires parameters are introduced as pack expansions. - ++cp_unevaluated_operand; - result = cp_walk_tree (&REQUIRES_EXPR_REQS (*tp), func, data, pset); - --cp_unevaluated_operand; - *walk_subtrees_p = 0; - break; + { + cp_unevaluated u; + for (tree parm = REQUIRES_EXPR_PARMS (*tp); parm; parm = DECL_CHAIN (parm)) + /* Walk the types of each parameter, but not the parameter itself, + since doing so would cause false positives in the unexpanded pack + checker if the requires-expr introduces a function parameter pack, + e.g. requires (Ts... ts) { }. */ + WALK_SUBTREE (TREE_TYPE (parm)); + WALK_SUBTREE (REQUIRES_EXPR_REQS (*tp)); + *walk_subtrees_p = 0; + break; + } case DECL_EXPR: /* User variables should be mentioned in BIND_EXPR_VARS diff --git a/gcc/testsuite/g++.dg/cpp2a/concepts-requires33.C b/gcc/testsuite/g++.dg/cpp2a/concepts-requires33.C new file mode 100644 index 00000000000..1ff237ac382 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp2a/concepts-requires33.C @@ -0,0 +1,10 @@ +// PR c++/107417 +// { dg-do compile { target c++20 } } + +template +void f() requires (requires (T x) { true; } && ...); + +int main() { + f(); + f(); // { dg-error "no match" } +}