[gcc r13-4544] c: Diagnose auto constexpr used with a type

[gcc r13-4544] c: Diagnose auto constexpr used with a type

[Joseph Myers]

https://gcc.gnu.org/g:3db5bee0079d48ab7c82f8df1cc7efd87a6fed04

commit r13-4544-g3db5bee0079d48ab7c82f8df1cc7efd87a6fed04
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Dec 7 22:08:18 2022 +0000

    c: Diagnose auto constexpr used with a type
    
    The constraints on auto in C2x disallow use with other storage-class
    specifiers unless the type is inferred from an initializer.  That
    includes constexpr; add the missing checks for this case (the
    combination of auto, constexpr and a type specifier).
    
    Bootstrapped with no regressions for x86_64-pc-linux-gnu.
    
    gcc/c/
            * c-decl.cc (declspecs_add_type, declspecs_add_scspec): Check for
            auto, constexpr and a type used together.
    
    gcc/testsuite/
            * gcc.dg/c2x-constexpr-1.c: Do not use auto, constexpr and a type
            together.
            * gcc.dg/c2x-constexpr-3.c: Add tests of auto, constexpr and type
            used together.

Diff:
---
 gcc/c/c-decl.cc                        | 12 ++++++++++++
 gcc/testsuite/gcc.dg/c2x-constexpr-1.c |  4 ++--
 gcc/testsuite/gcc.dg/c2x-constexpr-3.c |  8 ++++++++
 3 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc
index 111f05e2a40..e47ca6718b3 100644
--- a/gcc/c/c-decl.cc
+++ b/gcc/c/c-decl.cc
@@ -11430,6 +11430,10 @@ declspecs_add_type (location_t loc, struct c_declspecs *specs,
       else if (specs->thread_p)
 	error ("%qs used with %<auto%>",
 	       specs->thread_gnu_p ? "__thread" : "_Thread_local");
+      else if (specs->constexpr_p)
+	/* auto may only be used with another storage class specifier,
+	   such as constexpr, if the type is inferred.  */
+	error ("%<auto%> used with %<constexpr%>");
       else
 	specs->storage_class = csc_auto;
     }
@@ -12363,6 +12367,10 @@ declspecs_add_scspec (location_t loc,
 	  return specs;
 	}
       n = csc_auto;
+      /* auto may only be used with another storage class specifier,
+	 such as constexpr, if the type is inferred.  */
+      if (specs->constexpr_p)
+	error ("%qE used with %<constexpr%>", scspec);
       break;
     case RID_EXTERN:
       n = csc_extern;
@@ -12393,6 +12401,10 @@ declspecs_add_scspec (location_t loc,
 	error ("%qE used with %<extern%>", scspec);
       else if (specs->storage_class == csc_typedef)
 	error ("%qE used with %<typedef%>", scspec);
+      else if (specs->storage_class == csc_auto)
+	/* auto may only be used with another storage class specifier,
+	   such as constexpr, if the type is inferred.  */
+	error ("%qE used with %<auto%>", scspec);
       else if (specs->thread_p)
 	error ("%qE used with %qs", scspec,
 	       specs->thread_gnu_p ? "__thread" : "_Thread_local");
diff --git a/gcc/testsuite/gcc.dg/c2x-constexpr-1.c b/gcc/testsuite/gcc.dg/c2x-constexpr-1.c
index f7f64e2d300..d43d95ddd7c 100644
--- a/gcc/testsuite/gcc.dg/c2x-constexpr-1.c
+++ b/gcc/testsuite/gcc.dg/c2x-constexpr-1.c
@@ -180,10 +180,10 @@ f0 ()
 {
   constexpr int fv0 = 3;
   static_assert (fv0 == 3);
-  auto constexpr int fv1 = 4;
+  auto constexpr fv1 = 4;
   static_assert (fv1 == 4);
   register constexpr float fv2 = 1.0;
-  constexpr auto int fv3 = 123;
+  constexpr auto fv3 = 123;
   static_assert (fv3 == 123);
   constexpr register void *fv4 = (void *) 0;
   const int *fv5 = &(constexpr int) { 234 };
diff --git a/gcc/testsuite/gcc.dg/c2x-constexpr-3.c b/gcc/testsuite/gcc.dg/c2x-constexpr-3.c
index 16e56db2835..29fedc03afd 100644
--- a/gcc/testsuite/gcc.dg/c2x-constexpr-3.c
+++ b/gcc/testsuite/gcc.dg/c2x-constexpr-3.c
@@ -225,4 +225,12 @@ f0 ()
   constexpr typeof (nullptr) not_npc = nullptr;
   int *ptr = 0;
   (void) (ptr == not_npc); /* { dg-error "invalid operands" } */
+  /* auto may only be used with another storage class specifier, such as
+     constexpr, if the type is inferred.  */
+  auto constexpr int a_c_t = 1; /* { dg-error "'auto' used with 'constexpr'" } */
+  constexpr auto int c_a_t = 1; /* { dg-error "'auto' used with 'constexpr'" } */
+  auto int constexpr a_t_c = 1; /* { dg-error "'constexpr' used with 'auto'" } */
+  constexpr int auto c_t_a = 1; /* { dg-error "'auto' used with 'constexpr'" } */
+  int auto constexpr t_a_c = 1; /* { dg-error "'constexpr' used with 'auto'" } */
+  int constexpr auto t_c_a = 1; /* { dg-error "'auto' used with 'constexpr'" } */
 }