From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 3B5BF396C5D1; Sun, 11 Dec 2022 13:46:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3B5BF396C5D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1670766363; bh=0VGs6TkV2c5RNRf7y+t0e2jkEjoDhOe7rfZmaCZByc0=; h=From:To:Subject:Date:From; b=WKziXcsyAqkzw548JPV/iOfgnRwvm9H1l5tWWpyZqjtWwSbDg1bDPuR7Q+TFcylD1 1HmSo/neEhT6+wrBm/qcOhmusrgqOe6mDXCpw9erEI+qeG40DpNMlnXEHSVtYpdcAE bdsO3o2chLfu+jVChYt6j0lb5QDVsgPtht08Trfo= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-4600] tree-optimization/89317 - missed folding of (p + 4) - &p->d X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: 26295a069fd312a8be4a6cd96643117383145cc0 X-Git-Newrev: d13b86f932ff7b9d8f41483fd869c637b67d4dec Message-Id: <20221211134603.3B5BF396C5D1@sourceware.org> Date: Sun, 11 Dec 2022 13:46:03 +0000 (GMT) List-Id: https://gcc.gnu.org/g:d13b86f932ff7b9d8f41483fd869c637b67d4dec commit r13-4600-gd13b86f932ff7b9d8f41483fd869c637b67d4dec Author: Richard Biener Date: Sun Dec 11 14:07:34 2022 +0100 tree-optimization/89317 - missed folding of (p + 4) - &p->d The PR notices we fail to simplify a_4 = &x_3(D)->data; b_5 = x_3(D) + 16; _1 = b_5 - a_4; together with the enabler handling ADDR_EXPR leafs in separate stmts in match.pd the suggested patterns work. PR tree-optimization/89317 * match.pd ((p + b) - &p->c -> b - offsetof(c)): New patterns. * gcc.dg/tree-ssa/pr89317.c: New testcase. Diff: --- gcc/match.pd | 11 +++++++++++ gcc/testsuite/gcc.dg/tree-ssa/pr89317.c | 13 +++++++++++++ 2 files changed, 24 insertions(+) diff --git a/gcc/match.pd b/gcc/match.pd index 046ea2cdef4..ba83c69734f 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -2451,6 +2451,17 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (with { poly_int64 diff; } (if (ptr_difference_const (@0, @2, &diff)) (plus { build_int_cst_type (type, diff); } (convert (minus @1 @3)))))) +/* (p + b) - &p->d -> offsetof (*p, d) + b */ +(simplify + (pointer_diff (pointer_plus @0 @1) ADDR_EXPR@2) + (with { poly_int64 diff; } + (if (ptr_difference_const (@0, @2, &diff)) + (plus { build_int_cst_type (type, diff); } (convert @1))))) +(simplify + (pointer_diff ADDR_EXPR@0 (pointer_plus @1 @2)) + (with { poly_int64 diff; } + (if (ptr_difference_const (@0, @1, &diff)) + (minus { build_int_cst_type (type, diff); } (convert @2))))) /* Canonicalize (T *)(ptr - ptr-cst) to &MEM[ptr + -ptr-cst]. */ (simplify diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr89317.c b/gcc/testsuite/gcc.dg/tree-ssa/pr89317.c new file mode 100644 index 00000000000..0d0a049454f --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr89317.c @@ -0,0 +1,13 @@ +/* { dg-do compile } */ +/* { dg-options "-O -fdump-tree-ccp1" } */ + +struct b { int data[16]; }; + +int foo (struct b *x) +{ + int *a = x->data; + int *b = ((int*)x) + 4; + return b - a; +} + +/* { dg-final { scan-tree-dump "return 4;" "ccp1" } } */