public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-8978] tree-optimization/107865 - ICE with outlining of loops
Date: Mon, 12 Dec 2022 11:21:03 +0000 (GMT)	[thread overview]
Message-ID: <20221212112103.171533AA9423@sourceware.org> (raw)

https://gcc.gnu.org/g:09469705318de7a0fe5f10f5d5b92870d3fada6e

commit r12-8978-g09469705318de7a0fe5f10f5d5b92870d3fada6e
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Nov 25 08:27:42 2022 +0100

    tree-optimization/107865 - ICE with outlining of loops
    
    The following makes sure to clear loops number of iterations when
    outlining them as part of a SESE region as can happen with
    auto-parallelization.  The referenced SSA names become stale otherwise.
    
            PR tree-optimization/107865
            * tree-cfg.cc (move_sese_region_to_fn): Free the number of
            iterations of moved loops.
    
            * gfortran.dg/graphite/pr107865.f90: New testcase.
    
    (cherry picked from commit bcc2449384f2092cbdf5d6ac2357aeabe3212b2e)

Diff:
---
 gcc/testsuite/gfortran.dg/graphite/pr107865.f90 | 18 ++++++++++++++++++
 gcc/tree-cfg.cc                                 |  2 ++
 2 files changed, 20 insertions(+)

diff --git a/gcc/testsuite/gfortran.dg/graphite/pr107865.f90 b/gcc/testsuite/gfortran.dg/graphite/pr107865.f90
new file mode 100644
index 00000000000..6bddb17a1be
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/graphite/pr107865.f90
@@ -0,0 +1,18 @@
+! { dg-do compile }
+! { dg-options "-O1 -floop-parallelize-all -ftree-parallelize-loops=2" }
+
+      SUBROUTINE FNC (F)
+
+      IMPLICIT REAL (A-H)
+      DIMENSION F(N)
+
+      DO I = 1, 6
+         DO J = 1, 6
+            IF (J .NE. I) THEN
+               F(I) = F(I) + 1
+            END IF
+         END DO
+      END DO
+
+      RETURN
+      END
diff --git a/gcc/tree-cfg.cc b/gcc/tree-cfg.cc
index c0824e34802..05fc4514714 100644
--- a/gcc/tree-cfg.cc
+++ b/gcc/tree-cfg.cc
@@ -7737,6 +7737,8 @@ move_sese_region_to_fn (struct function *dest_cfun, basic_block entry_bb,
       if (bb->loop_father->header == bb)
 	{
 	  class loop *this_loop = bb->loop_father;
+	  /* Avoid the need to remap SSA names used in nb_iterations.  */
+	  free_numbers_of_iterations_estimates (this_loop);
 	  class loop *outer = loop_outer (this_loop);
 	  if (outer == loop
 	      /* If the SESE region contains some bbs ending with

                 reply	other threads:[~2022-12-12 11:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221212112103.171533AA9423@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).