public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Martin Liska <marxin@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-4696] mklog: do not depend on recent unidiff version
Date: Wed, 14 Dec 2022 10:35:24 +0000 (GMT)	[thread overview]
Message-ID: <20221214103524.38E353835899@sourceware.org> (raw)

https://gcc.gnu.org/g:e165214777acfe5621ad36e55b16e098d50e1596

commit r13-4696-ge165214777acfe5621ad36e55b16e098d50e1596
Author: Martin Liska <mliska@suse.cz>
Date:   Wed Dec 14 11:33:25 2022 +0100

    mklog: do not depend on recent unidiff version
    
    contrib/ChangeLog:
    
            * mklog.py: Check for number of hunks and not if a modified
            file is binary.

Diff:
---
 contrib/mklog.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/contrib/mklog.py b/contrib/mklog.py
index 358b7fc6b8b..5dea8a05c0c 100755
--- a/contrib/mklog.py
+++ b/contrib/mklog.py
@@ -186,8 +186,9 @@ def generate_changelog(data, no_functions=False, fill_pr_titles=False,
             # contains commented code which a note that it
             # has not been tested due to a certain PR or DR.
             this_file_prs = []
-            if not file.is_binary_file:
-                for line in list(file)[0][0:10]:
+            hunks = list(file)
+            if hunks:
+                for line in hunks[0][0:10]:
                     m = pr_regex.search(line.value)
                     if m:
                         pr = m.group('pr')

                 reply	other threads:[~2022-12-14 10:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221214103524.38E353835899@sourceware.org \
    --to=marxin@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).