public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Thomas Schwinge <tschwinge@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc/devel/rust/master] Revert "ci: Apply warnings in CI"
Date: Wed, 14 Dec 2022 15:40:02 +0000 (GMT)	[thread overview]
Message-ID: <20221214154002.CC196382BE84@sourceware.org> (raw)

https://gcc.gnu.org/g:1664a730882db16aae7db752b45c95fe540ea41f

commit 1664a730882db16aae7db752b45c95fe540ea41f
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Wed Dec 14 09:45:58 2022 +0100

    Revert "ci: Apply warnings in CI"
    
    As discussed in
    <https://inbox.sourceware.org/gcc-patches/871qpjtmd8.fsf@euler.schwinge.homeip.net>:
    
    > '-Werror=overloaded-virtual' is implied as by default, we have
    > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds].
    > ([...])
    > (Maybe that isn't active for '--disable-bootstrap' builds, but that's
    > "OK".)
    
    For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any
    new such diagnostics will be caught by the #1026 "check for new warnings"
    machinery, so effectively that does implement '-Werror', too.
    
    > '-Wno-unused-parameter' [did] move into
    > 'rust-warn'
    
    This reverts #1585 commit a32ef7aa18c45e7047f539b11cd572f0f9502b6d.

Diff:
---
 .github/workflows/ccpp.yml | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/.github/workflows/ccpp.yml b/.github/workflows/ccpp.yml
index 8c9f027cf36..c7d27ce2fcd 100644
--- a/.github/workflows/ccpp.yml
+++ b/.github/workflows/ccpp.yml
@@ -8,9 +8,6 @@ on:
   pull_request:
     branches: [ master ]
 
-env:
-  CXXFLAGS: "-Wno-unused-parameter -Werror=overloaded-virtual"
-
 jobs:
   build-and-check-ubuntu-64bit:

                 reply	other threads:[~2022-12-14 15:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221214154002.CC196382BE84@sourceware.org \
    --to=tschwinge@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).