From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id E56633834E26; Fri, 16 Dec 2022 09:29:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E56633834E26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1671182950; bh=vf6HzsILdatDEhcYqTGQUusVlGbEinPprVeZKsNoVmc=; h=From:To:Subject:Date:From; b=sgzotaZ9Xq0qyRdUWjNDaZuLos3B1UnLV9Fb+uTgjT+bF+Oa+Xh579oIwIhvQXrjP dcNH+kq+xKsh7coPGL4lkcCvQuoUgnB/6Sq4Fx0FT05WmfgCGIN4+T+D7LN3xscx1g QPDTdohKvp+ZR+r2dtD0BqAskjFebw917PS4UZkY= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-4740] middle-end/108086 - remove PR28238 fix superseeded by PR34018 fix X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: ddcaa60983b50378bde1b7e327086fe0ce101795 X-Git-Newrev: 340ddeae6611f6ab524211a009e97a85b4bba549 Message-Id: <20221216092910.E56633834E26@sourceware.org> Date: Fri, 16 Dec 2022 09:29:10 +0000 (GMT) List-Id: https://gcc.gnu.org/g:340ddeae6611f6ab524211a009e97a85b4bba549 commit r13-4740-g340ddeae6611f6ab524211a009e97a85b4bba549 Author: Richard Biener Date: Fri Dec 16 09:46:25 2022 +0100 middle-end/108086 - remove PR28238 fix superseeded by PR34018 fix There's quite special code in copy_bb that handles inline substitution of a non-invariant address in place of an invariant one that's now handled by more generic handling of this case in remap_gimple_op_r so this removes the special casing that happens in a hot path, providing a small speedup. PR middle-end/108086 * tree-inline.cc (copy_bb): Remove handling of (foo *)&this->m substitution which is done in remap_gimple_op_r via re-gimplifying. Diff: --- gcc/tree-inline.cc | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/gcc/tree-inline.cc b/gcc/tree-inline.cc index 02d8c39c3e8..9fd971a034c 100644 --- a/gcc/tree-inline.cc +++ b/gcc/tree-inline.cc @@ -2074,21 +2074,6 @@ copy_bb (copy_body_data *id, basic_block bb, gimple_duplicate_stmt_histograms (cfun, stmt, id->src_cfun, orig_stmt); - /* With return slot optimization we can end up with - non-gimple (foo *)&this->m, fix that here. */ - if (is_gimple_assign (stmt) - && CONVERT_EXPR_CODE_P (gimple_assign_rhs_code (stmt)) - && !is_gimple_val (gimple_assign_rhs1 (stmt))) - { - tree new_rhs; - new_rhs = force_gimple_operand_gsi (&seq_gsi, - gimple_assign_rhs1 (stmt), - true, NULL, false, - GSI_CONTINUE_LINKING); - gimple_assign_set_rhs1 (stmt, new_rhs); - id->regimplify = false; - } - gsi_insert_after (&seq_gsi, stmt, GSI_NEW_STMT); if (id->regimplify)