From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2140) id CDE57385B50A; Fri, 23 Dec 2022 00:58:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDE57385B50A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1671757083; bh=EC4da/CBtL753vUauVJfJ12EFWx6qTa2TE/jivYCXM8=; h=From:To:Subject:Date:From; b=hT0sfhRadlXao2PBDInNyKl8eRGvL4Egi2KbO0upDkYRc6cU543a9xN2+lV5UOvUQ KkvhbglOppKaZBflzoWuMmRfipIijCCnio4jl3fp90hFkNfAphh5C+M/hpYq8wcthP jrL0ziS8Z5iHHKW+QFvgut4PZz1731EwBA2+65lc= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Alexandre Oliva To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/aoliva/heads/testme)] hash set: reject attempts to insert null pointers X-Act-Checkin: gcc X-Git-Author: Alexandre Oliva X-Git-Refname: refs/users/aoliva/heads/testme X-Git-Oldrev: 805feed9366806f7ff54c2a3d3f9d31131df8013 X-Git-Newrev: a655804c5d6e60a6a019a1c7f33d48549a823bf5 Message-Id: <20221223005803.CDE57385B50A@sourceware.org> Date: Fri, 23 Dec 2022 00:58:03 +0000 (GMT) List-Id: https://gcc.gnu.org/g:a655804c5d6e60a6a019a1c7f33d48549a823bf5 commit a655804c5d6e60a6a019a1c7f33d48549a823bf5 Author: Alexandre Oliva Date: Thu Dec 22 21:28:48 2022 -0300 hash set: reject attempts to insert null pointers Diff: --- gcc/hash-set.h | 6 +++++- gcc/varpool.cc | 4 +++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gcc/hash-set.h b/gcc/hash-set.h index 76fa7f39456..a98121a060e 100644 --- a/gcc/hash-set.h +++ b/gcc/hash-set.h @@ -58,7 +58,11 @@ public: Key *e = m_table.find_slot_with_hash (k, Traits::hash (k), INSERT); bool existed = !Traits::is_empty (*e); if (!existed) - new (e) Key (k); + { + new (e) Key (k); + // Catch attempts to insert e.g. a NULL pointer. + gcc_checking_assert (!Traits::is_empty (*e)); + } return existed; } diff --git a/gcc/varpool.cc b/gcc/varpool.cc index bfd17f1250c..ccbd6e50f4b 100644 --- a/gcc/varpool.cc +++ b/gcc/varpool.cc @@ -680,10 +680,12 @@ symbol_table::remove_unreferenced_decls (void) enqueue_node (vnode, &first); else { - referenced.add (vnode); + if (vnode) + referenced.add (vnode); while (vnode && vnode->alias && vnode->definition) { vnode = vnode->get_alias_target (); + gcc_checking_assert (vnode); referenced.add (vnode); } }