public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/aoliva/heads/testme)] hash-map: reject empty-looking insertions Date: Fri, 23 Dec 2022 05:27:07 +0000 (GMT) [thread overview] Message-ID: <20221223052707.B5AB33857C44@sourceware.org> (raw) https://gcc.gnu.org/g:e730e22ec8b6d18f00dcef3e9f8ca3e2562b8be4 commit e730e22ec8b6d18f00dcef3e9f8ca3e2562b8be4 Author: Alexandre Oliva <oliva@gnu.org> Date: Thu Dec 22 21:28:49 2022 -0300 hash-map: reject empty-looking insertions Diff: --- gcc/hash-map.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gcc/hash-map.h b/gcc/hash-map.h index 457967f4bf1..63fa21cf37c 100644 --- a/gcc/hash-map.h +++ b/gcc/hash-map.h @@ -169,11 +169,12 @@ public: { hash_entry *e = m_table.find_slot_with_hash (k, Traits::hash (k), INSERT); - bool ins = hash_entry::is_empty (*e); + bool ins = Traits::is_empty (*e); if (ins) { e->m_key = k; new ((void *) &e->m_value) Value (v); + gcc_checking_assert (!Traits::is_empty (*e)); } else e->m_value = v; @@ -203,6 +204,7 @@ public: { e->m_key = k; new ((void *)&e->m_value) Value (); + gcc_checking_assert (!Traits::is_empty (*e)); } if (existed != NULL)
next reply other threads:[~2022-12-23 5:27 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-23 5:27 Alexandre Oliva [this message] -- strict thread matches above, loose matches on Subject: below -- 2022-12-28 5:23 Alexandre Oliva 2022-12-23 7:31 Alexandre Oliva 2022-12-23 0:58 Alexandre Oliva
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221223052707.B5AB33857C44@sourceware.org \ --to=aoliva@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).