[gcc(refs/users/aoliva/heads/testme)] [C++] constexpr: request insert iff depth is ok

[Alexandre Oliva <aoliva@gcc.gnu.org>]

https://gcc.gnu.org/g:0323b06b60b328fd293d20a707951b7b10be4bc0

commit 0323b06b60b328fd293d20a707951b7b10be4bc0
Author: Alexandre Oliva <oliva@gnu.org>
Date:   Fri Dec 23 02:25:54 2022 -0300

    [C++] constexpr: request insert iff depth is ok

Diff:
---
 gcc/cp/constexpr.cc | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gcc/cp/constexpr.cc b/gcc/cp/constexpr.cc
index d99c49bdbe2..6d20ffa2cde 100644
--- a/gcc/cp/constexpr.cc
+++ b/gcc/cp/constexpr.cc
@@ -3000,13 +3000,15 @@ cxx_eval_call_expression (const constexpr_ctx *ctx, tree t,
 
       /* If we have seen this call before, we are done.  */
       maybe_initialize_constexpr_call_table ();
+      bool insert = depth_ok < constexpr_cache_depth;
       constexpr_call **slot
-	= constexpr_call_table->find_slot (&new_call, INSERT);
-      entry = *slot;
+	= constexpr_call_table->find_slot (&new_call,
+					   insert ? INSERT : NO_INSERT);
+      entry = slot ? *slot : NULL;
       if (entry == NULL)
 	{
 	  /* Only cache up to constexpr_cache_depth to limit memory use.  */
-	  if (depth_ok < constexpr_cache_depth)
+	  if (insert)
 	    {
 	      /* We need to keep a pointer to the entry, not just the slot, as
 		 the slot can move during evaluation of the body.  */