From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2093) id DC2B9385703F; Fri, 23 Dec 2022 05:42:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC2B9385703F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1671774153; bh=kWUHkxuYkzlh684YUZLiKoPCQUX9jCG+MTPtnQgxsfc=; h=From:To:Subject:Date:From; b=HAyxmKlIrlnldSYueRegBB5awHOMp0WXkuLbYOjyfGoKe0R7XLj7H6ehk9fwgRY1T Deg2odF3Y1k0wVIGStml90EDKyP98e9EgRMhaNFuuRbIp/GMzRryZubrA0c4jmBOKr N/P1h6NpDCFu4fcYgvyWRDOL0Sx+8ASO9/gRKGCY= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Kito Cheng To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-4864] RISC-V: Fix incorrect annotation X-Act-Checkin: gcc X-Git-Author: Ju-Zhe Zhong X-Git-Refname: refs/heads/master X-Git-Oldrev: 85112fbbfd939f87fb12a00e40ab423ddcfa8ca1 X-Git-Newrev: 9374f766a75bf898e717a5bbb58199a91528af0b Message-Id: <20221223054233.DC2B9385703F@sourceware.org> Date: Fri, 23 Dec 2022 05:42:33 +0000 (GMT) List-Id: https://gcc.gnu.org/g:9374f766a75bf898e717a5bbb58199a91528af0b commit r13-4864-g9374f766a75bf898e717a5bbb58199a91528af0b Author: Ju-Zhe Zhong Date: Tue Dec 20 07:13:54 2022 +0800 RISC-V: Fix incorrect annotation gcc/ChangeLog: * config/riscv/riscv-vsetvl.cc (anticipatable_occurrence_p): Fix incorrect annotations. (available_occurrence_p): Ditto. (backward_propagate_worthwhile_p): Ditto. (can_backward_propagate_p): Ditto. Diff: --- gcc/config/riscv/riscv-vsetvl.cc | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/gcc/config/riscv/riscv-vsetvl.cc b/gcc/config/riscv/riscv-vsetvl.cc index 0c2ff630e96..72f1e4059ab 100644 --- a/gcc/config/riscv/riscv-vsetvl.cc +++ b/gcc/config/riscv/riscv-vsetvl.cc @@ -186,7 +186,7 @@ anticipatable_occurrence_p (const insn_info *insn, const vector_insn_info dem) /* The only possible operand we care of VSETVL is AVL. */ if (dem.has_avl_reg ()) { - /* The operands shoule not be modified in the basic block prior + /* The operands should not be modified in the basic block prior to the occurrence. */ if (!vlmax_avl_p (dem.get_avl ())) { @@ -223,7 +223,7 @@ available_occurrence_p (const insn_info *insn, const vector_insn_info dem) /* The only possible operand we care of VSETVL is AVL. */ if (dem.has_avl_reg ()) { - /* The operands shoule not be modified in the basic block prior + /* The operands should not be modified in the basic block prior to the occurrence. e.g. bb: @@ -284,7 +284,7 @@ backward_propagate_worthwhile_p (const basic_block cfg_bb, |_________| reaching_out Header is incompatible with reaching_out and the block is loop itself, - we don't backward propagete the local_dem since we can't avoid emit + we don't backward propagate the local_dem since we can't avoid emit vsetvl for the local_dem. */ edge e; edge_iterator ei; @@ -334,10 +334,10 @@ can_backward_propagate_p (const function_info *ssa, const basic_block cfg_bb, insn_info *insn = prop.get_insn (); /* TODO: We don't backward propagate the explict VSETVL here - since we will change vsetvl and vsetvlmax intrinsiscs into - no side effects which can be optimized into optimzal location - by GCC internal PASSes. We only need to support these backward - propagation if vsetvl instrinsics have side effects. */ + since we will change vsetvl and vsetvlmax intrinsics into + no side effects which can be optimized into optimal location + by GCC internal passes. We only need to support these backward + propagation if vsetvl intrinsics have side effects. */ if (vsetvl_insn_p (insn->rtl ())) return false; @@ -369,7 +369,7 @@ can_backward_propagate_p (const function_info *ssa, const basic_block cfg_bb, def_info *def = find_access (insn->uses (), REGNO (reg))->def (); /* If the definition is in the current block, we can't propagate it - acrocss blocks. */ + across blocks. */ if (def->bb ()->cfg_bb ()->index == insn->bb ()->cfg_bb ()->index) { set_info *set = safe_dyn_cast (def); @@ -406,7 +406,7 @@ can_backward_propagate_p (const function_info *ssa, const basic_block cfg_bb, if (def->bb ()->cfg_bb ()->index == cfg_bb->index) return true; - /* Make sure we don't backward propagete the VL/VTYPE info over the + /* Make sure we don't backward propagate the VL/VTYPE info over the definition blocks. */ bool visited_p = false; for (const bb_info *bb : ssa->reverse_bbs ())