public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Marc Poulhi?s <dkm@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-4964] ada: Another small adjustment to special resolution of membership test Date: Tue, 3 Jan 2023 09:34:04 +0000 (GMT) [thread overview] Message-ID: <20230103093404.30C803858414@sourceware.org> (raw) https://gcc.gnu.org/g:48d9f7cb215f1af996788aee07808339a786a18d commit r13-4964-g48d9f7cb215f1af996788aee07808339a786a18d Author: Eric Botcazou <ebotcazou@adacore.com> Date: Wed Dec 7 17:54:37 2022 +0100 ada: Another small adjustment to special resolution of membership test This goes back to the original implementation but keeps the special size test with universal_integer to cope with its limited range. gcc/ada/ * sem_res.adb (Resolve_Membership_Op): Adjust again latest change. Diff: --- gcc/ada/sem_res.adb | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/gcc/ada/sem_res.adb b/gcc/ada/sem_res.adb index b54ed93a7f7..348d272a399 100644 --- a/gcc/ada/sem_res.adb +++ b/gcc/ada/sem_res.adb @@ -10105,11 +10105,11 @@ package body Sem_Res is then T := Etype (R); - -- If the type of the left operand is universal_integer and that of the - -- right operand is smaller, then we do not resolve the operands to the - -- tested type but to universal_integer instead. If not conforming to - -- the letter, it's conforming to the spirit of the specification of - -- membership tests, which are typically used to guard an operation and + -- If the left operand is of a universal numeric type and the right + -- operand is not, we do not resolve the operands to the tested type + -- but to the universal type instead. If not conforming to the letter, + -- it's conforming to the spirit of the specification of membership + -- tests, which are typically used to guard a specific operation and -- ought not to fail a check in doing so. Without this, in the case of -- type Small_Length is range 1 .. 16; @@ -10127,9 +10127,14 @@ package body Sem_Res is -- for example the large values of Long_Long_Long_Unsigned. elsif not Is_Overloaded (L) - and then Etype (L) = Universal_Integer + and then Is_Universal_Numeric_Type (Etype (L)) and then (Is_Overloaded (R) - or else RM_Size (Etype (R)) < RM_Size (Universal_Integer)) + or else + (not Is_Universal_Numeric_Type (Etype (R)) + and then + (not Is_Integer_Type (Etype (R)) + or else + RM_Size (Etype (R)) < RM_Size (Universal_Integer)))) then T := Etype (L);
reply other threads:[~2023-01-03 9:34 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230103093404.30C803858414@sourceware.org \ --to=dkm@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).